Skip to content

Fix ListTunnelPorts in Go #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasongin merged 1 commit into from
Aug 25, 2025
Merged

Fix ListTunnelPorts in Go #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions go/tunnels/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,8 +410,8 @@ func (m *Manager) ListTunnelPorts(
return nil, fmt.Errorf("error parsing response json to tunnel ports: %w", err)
}

for _, port := range tunnelPortsResponse.Value {
tp = append(tp, &port)
for i := range tunnelPortsResponse.Value {
tp = append(tp, &tunnelPortsResponse.Value[i])
}

return tp, nil
Expand Down
9 changes: 9 additions & 0 deletions go/tunnels/manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,15 @@ func TestTunnelListPorts(t *testing.T) {
if len(ports) != 2 {
t.Errorf("ports not successfully listed")
}

if ports[0].PortNumber != 3000 {
t.Errorf("port 3000 not successfully listed")
}

if ports[1].PortNumber != 3001 {
t.Errorf("port 3001 not successfully listed")
}

for _, port := range ports {
logger.Printf("Port: %d", port.PortNumber)
port.Table().Print()
Expand Down
2 changes: 1 addition & 1 deletion go/tunnels/tunnels.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"github.com/rodaine/table"
)

const PackageVersion = "0.1.18"
const PackageVersion = "0.1.19"

func (tunnel *Tunnel) requestObject() (*Tunnel, error) {
convertedTunnel := &Tunnel{
Expand Down