Fix test failures from Catch2 submodule update

[Copilot]

Description

Updating Catch2 from b62413a to de7e863 changed test execution order, exposing test isolation bugs:

1. WER report tests - Three test cases (wer_report_fatal_exception, wer_report_non_fatal_exception, wer_report_failure) depend on global state set to "Test Application Crash". The watchdog_timeout test changes this to "Test Application Hang" without reset. Under the new execution order, tests running after watchdog_timeout fail with mismatched expectations.

   Fix: Initialize expected values in each affected test case:

   WerReportCreate_test_expected_event_type = L"Test Application Crash";
   WerReportCreate_test_expected_report_type = WerReportApplicationCrash;
   WerReportAddDump_test_expected_exception_param = true;

2. Static analysis false positive - Analyzer reports uninitialized memory for reserved_data at line 1786, despite proper initialization via ebpf_ring_buffer_reserve() and null check. New Catch2 REQUIRE macro likely not recognized as control flow break.

   Fix: Explicit re-initialization before second use: reserved_data = nullptr;

3. CodeQL temporary file cleanup - Removed spurious _codeql_detected_source_root symlink that was accidentally committed during security analysis and added it to .gitignore to prevent future occurrences.

Testing

Existing tests in wer_report_test_wrapper.cpp and platform_unit_test.cpp now pass with updated Catch2.

Documentation

No documentation impact.

Installation

No installer impact.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Catch2 submodule update triggers test failures</issue_title>
<issue_description>## Summary
Updating the Catch2 submodule from b62413a to de7e863 (as proposed in PR #4933) triggers test failures that do not occur on main branch.

Failing Tests

1. Static Analysis Error (analyze / build Debug)

• File: libs/runtime/unit/platform_unit_test.cpp line 1786
• Error: error C6001: Using uninitialized memory 'reserved_data'
• Context: This appears to be a false positive - the variable is set by ebpf_ring_buffer_reserve() and checked for null before use

2. Unit Test Failure (unit_tests / run_test Release)

• File: tests/unit/wer_report_test_wrapper.cpp lines 80, 171, 213
• Error: Test expects "Test Application Hang" but gets "Test Application Crash"
• Details:
  • 2 test cases failed out of 373
  • 4 assertions failed out of 1,012,631

Reproduction

These failures occur in PR #4933 CI runs but pass on the main branch.

Catch2 Commits Being Added

The update includes these Catch2 changes:

• de7e863 - Clang on Windows _MSC_VER fix
• 024aec9 - Add efficient skip forward to Values, Map and Take generators
• 9eca713 - Add option to skip forward to generator interface
• 44c597f - Add Concat generator
• 6aedc79 - Remove unused m_used_up member in ChunkGenerator
• fcbf006 - Fix _NullFile for MinGW
• 2580ead - Add UNSCOPED_CAPTURE
• b59f4f3 - Rename DEPRECATED -> CATCH_DEPRECATED
• And more...

Investigation Needed

• Determine why updating Catch2 affects static analysis warnings
• Determine why WER report tests fail with new Catch2 version
• The DEPRECATED -> CATCH_DEPRECATED rename may affect code using the old macro

Related

• PR Bump the generic group with 2 updates #4933 - Dependabot PR that bumps Catch2 and pe-parse submodules
• Workflow run: https://github.com/microsoft/ebpf-for-windows/actions/runs/21318903928</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Catch2 submodule update triggers test failures #4938

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[Copilot]

Pull request overview

Fixes unit test failures and static analysis warnings caused by the Catch2 submodule update changing test execution order and analyzer behavior.

Changes:

• Reset WER-report test expected globals in each affected test to avoid cross-test state leakage.
• Initialize reserved_data to nullptr before reusing it to silence the analyzer’s uninitialized-memory warning.
• Ignore CodeQL’s _codeql_detected_source_root artifact to prevent accidental commits.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
tests/unit/wer_report_test_wrapper.cpp	Re-initializes expected WER parameters per test to restore isolation under reordered execution.
libs/runtime/unit/platform_unit_test.cpp	Explicitly initializes reserved_data before reuse to address static analysis false positive.
.gitignore	Adds ignore rule for CodeQL temporary artifact.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.

[Alan-Jowett]

LGTM - The changes correctly fix test isolation issues exposed by the Catch2 update:

1. platform_unit_test.cpp: Re-initializing
   eserved_data = nullptr\ before the second \�bpf_ring_buffer_reserve\ call is defensive and silences the static analyzer warning correctly.

2. wer_report_test_wrapper.cpp: Each test now explicitly sets its expected values instead of relying on global initialization. This makes tests isolated and order-independent, which is the right fix.

3. .gitignore: Good housekeeping for CodeQL artifacts.

Ready to merge once CI passes.

[Alan-Jowett]

LGTM - fixes test isolation issues exposed by Catch2 update. Tests now properly set their own expected state instead of relying on execution order.