Fix km_ebpfcore_restart_test to run inside VM#5000
Open
Alan-Jowett wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix km_ebpfcore_restart_test to run inside VM#5000Alan-Jowett wants to merge 1 commit intomicrosoft:mainfrom
Alan-Jowett wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the km_ebpfcore_restart_test CI job by routing execution through the existing VM-based test execution path, ensuring the restart controller runs inside the Hyper-V VM where ebpfcore is installed.
Changes:
- Update the
km_ebpfcore_restart_testworkflow command to callexecute_ebpf_cicd_tests.ps1with a new stress-test option (RestartEbpfCore). - Add a
RestartEbpfCoreswitch toInvoke-CICDStressTeststo runebpf_restart_test_controller.exevia the standard VM test harness. - Plumb the new option through
vm_run_tests.psm1option parsing and intoInvoke-CICDStressTests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/cicd.yml |
Runs the restart test through execute_ebpf_cicd_tests.ps1 so it executes inside the VM. |
scripts/vm_run_tests.psm1 |
Recognizes RestartEbpfCore in -Options and forwards it to stress test invocation. |
scripts/run_driver_tests.psm1 |
Implements RestartEbpfCore handling in Invoke-CICDStressTests to execute the restart controller. |
The restart test controller was invoked directly on the 1ES runner host, but ebpfcore is installed inside the Hyper-V VM. This caused error 1060 (ERROR_SERVICE_DOES_NOT_EXIST) since the service doesn't exist on the host. Route the test through execute_ebpf_cicd_tests.ps1 with a new RestartEbpfCore stress test option, matching the pattern used by km_mt_stress_tests_restart_extension. Fixes microsoft#4950
c5538ff to
dc92354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
km_ebpfcore_restart_testhas been failing every scheduled run since it was introduced (issue #4950). The previous RCA (Chocolatey missing) was fixed by PR #4968, but the test continues to fail with a new error:Failed to create map, error: -1 Failed to open ebpfcore service, error: 1060 FAIL: ebpfcore service does not exist - environment issue!Root Cause
The test command
.\ebpf_restart_test_controller.exewas invoked directly on the 1ES runner host, but the eBPF components (ebpfcoreservice) are installed inside the Hyper-V VM (runner_vm) bysetup_ebpf_cicd_tests.ps1. Error 1060 isERROR_SERVICE_DOES_NOT_EXIST.Other KM tests (e.g.,
km_mt_stress_tests_restart_extension) correctly route execution throughexecute_ebpf_cicd_tests.ps1, which usesInvoke-OnHostOrVMto run inside the VM.Fix
Route the restart test through the existing VM execution infrastructure:
execute_ebpf_cicd_tests.ps1withRestartEbpfCoreoptionRestartEbpfCoreparameter toInvoke-CICDStressTestsFixes #4950