Switch from using choco to curl in pipeline#5255
Open
nmlud21 wants to merge 8 commits into
Open
Conversation
added 2 commits
May 11, 2026 12:17
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
nmlud21
requested review from
Alan-Jowett,
LakshK98,
dthaler,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag and
shankarseal
as code owners
nmlud21
changed the title
added 2 commits
May 12, 2026 16:43
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
nmlud21
force-pushed
the
download_from_curl
branch
from
f59fbe5 to
856ea74
Compare
added 3 commits
May 12, 2026 16:43
Alan-Jowett
previously approved these changes
May 13, 2026
nmlud21
dismissed
Alan-Jowett’s stale review
The merge-base changed after approval.
mikeagun
reviewed
May 14, 2026
| rm /tmp/Procdump.zip | ||
|
|
||
| # Extract current hash from workflow files. | ||
| OLD_HASH=$(grep -oP "PROCDUMP_EXPECTED_HASH: '\K[A-F0-9]+" \ |
Contributor
There was a problem hiding this comment.
This updates github reusable-test.yml, but not the azure reusable-test.yml expected hashes (also note the azure pipeline currently uses just $expectedHash for each of the hashes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5193
Testing
N/A
Documentation
No
Installation
No