Update-WdkVersion.ps1 now sorts by latest version#5258
Open
nmlud21 wants to merge 1 commit into
Open
Conversation
nmlud21
requested review from
Alan-Jowett,
LakshK98,
dthaler,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag and
shankarseal
as code owners
Signed-off-by: Nicholas Ludwig <nludwig@microsoft.com>
Alan-Jowett
approved these changes
May 13, 2026
mikeagun
requested changes
May 13, 2026
Contributor
mikeagun
left a comment
mikeagun
left a comment
There was a problem hiding this comment.
Looks good to me other than a (pre-existing) regex issue.
| } | ||
| $packageLine = $package | Where-Object { $_ -match $packageName } | ||
| if (-not $packageLine) { | ||
| $packageLines = $package | Where-Object { $_ -match "^$packageName\s+" } |
Contributor
There was a problem hiding this comment.
$packageName contains dots, which are regex wildcards. This is a pre-existing issue and doesn't seem likely to cause issues here, but using [regex]::Escape($packageName) for each of the -match and -replace patterns would avoid this ambiguity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update-WdkVersion.ps1can potentially select the wrong WDK version when NuGet returns multiple results. The script takes the first result fromnugetlist, but NuGet does not guarantee output order. This results in the latest version not always being chosen.This PR fixes this issue by sorting the output by version number to ensure the latest version is selected.
Resolves #5256
Testing
N/A
Documentation
No
Installation
No