Skip to content

Correct delete search param workflow#5629

Open
SergeyGaluzo wants to merge 17 commits into
mainfrom
users/sergal/delete-workflow
Open

Correct delete search param workflow#5629
SergeyGaluzo wants to merge 17 commits into
mainfrom
users/sergal/delete-workflow

Conversation

@SergeyGaluzo

@SergeyGaluzo SergeyGaluzo commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Fixes https://microsofthealth.visualstudio.com/Health/_workitems/edit/190743
User story has good explanation.
As far as implementation, I decided to keep as much of current pipeline logic as possible and remove resources from being deleted at the last stage in merge. Now, merge does not include resources for search params with pending delete and pending hard delete statuses.
I also decided to temporarily keep current logic to find resources for URLs based on full search param scan (handles current logic when resource deletes happen in the same SQL transaction with status updated). This should cover cases when current pending deletes are not yet processed by reindex. I will remove this fallback later when new logic lives in PROD for a while.

@SergeyGaluzo SergeyGaluzo requested a review from a team as a code owner June 20, 2026 04:33
SergeyGaluzo and others added 4 commits June 20, 2026 10:15
…o use Where'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…o use Where'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@codecov-commenter

codecov-commenter commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.90%. Comparing base (5f350b6) to head (51c416f).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5629      +/-   ##
==========================================
+ Coverage   76.89%   76.90%   +0.01%     
==========================================
  Files         997      997              
  Lines       36617    36724     +107     
  Branches     5529     5544      +15     
==========================================
+ Hits        28155    28243      +88     
- Misses       7113     7128      +15     
- Partials     1349     1353       +4     

see 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SergeyGaluzo and others added 6 commits June 21, 2026 17:11
…o local variable'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…o use Where'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@github-actions github-actions Bot added the SQL Scripts If SQL scripts are added to the PR label Jun 22, 2026
@SergeyGaluzo

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SQL Scripts If SQL scripts are added to the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants