Correct delete search param workflow#5629
Open
SergeyGaluzo wants to merge 17 commits into
Open
Conversation
…o use Where' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…o use Where' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5629 +/- ##
==========================================
+ Coverage 76.89% 76.90% +0.01%
==========================================
Files 997 997
Lines 36617 36724 +107
Branches 5529 5544 +15
==========================================
+ Hits 28155 28243 +88
- Misses 7113 7128 +15
- Partials 1349 1353 +4 🚀 New features to boost your workflow:
|
…o local variable' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…o use Where' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…rosoft/fhir-server into users/sergal/delete-workflow
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://microsofthealth.visualstudio.com/Health/_workitems/edit/190743
User story has good explanation.
As far as implementation, I decided to keep as much of current pipeline logic as possible and remove resources from being deleted at the last stage in merge. Now, merge does not include resources for search params with pending delete and pending hard delete statuses.
I also decided to temporarily keep current logic to find resources for URLs based on full search param scan (handles current logic when resource deletes happen in the same SQL transaction with status updated). This should cover cases when current pending deletes are not yet processed by reindex. I will remove this fallback later when new logic lives in PROD for a while.