-
Notifications
You must be signed in to change notification settings - Fork 231
Refresh FinOps hub upgrade procedure for multi-version FOCUS adoption #2123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: flanakin/focus14
Are you sure you want to change the base?
Changes from all commits
2c6fa8f
063eaaf
c886d19
6053f28
8ee2d63
463c273
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,8 +17,11 @@ | |
| - Each versioned function unions data from versioned tables in the Ingestion database and transforms it to that FOCUS version for back compat. | ||
| - Consumers should use the unversioned function for the latest and the versioned functions for back compat. | ||
|
|
||
| To add a new FOCUS versions: | ||
| To add a new FOCUS version: | ||
|
|
||
| 0. Confirm dependencies | ||
| 1. Ensure the FOCUS specification has been ratified for the target version. Support for working draft FOCUS versions should not be shipped before official ratification to prevent customer churn since FOCUS working drafts may change without notice. | ||
| 2. Check whether Microsoft Cost Management has shipped a matching FOCUS export dataset version. The hub depends on a `focuscost_X.Y.json` schema mapping file in [Microsoft.CostManagement/Exports/schemas](../modules/Microsoft.CostManagement/Exports/schemas/) when ingesting from Cost Management. If the export is not yet available, the hub schema can still ship as GA. Note the gap in the changelog so adopters know what additional setup will be required. | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The PR summary says step 0 should instruct shipping hub support as preview when the Cost Management export is not yet available, but this line says ship as GA (and data-model.md has no preview-convention text). Please reconcile the description with what shipped here. The body also lists "steps 5-8" but only 5-7 landed. |
||
| 1. Add schema mapping file | ||
| 1. Create new schema mapping file for the Cost Management export dataset version in the schemas folder | ||
| 2. Add file to file upload list in [storage.bicep](../modules/storage.bicep) | ||
|
|
@@ -41,3 +44,16 @@ To add a new FOCUS versions: | |
| 2. Update the KQL reports to use the new versioned functions | ||
| 3. Update the ADX dashboard to use the new versioned functions | ||
| 4. Update the FOCUS queries in the best practices library to use the new versioned functions | ||
| 5. Update open-data metadata | ||
| 1. Create a `FocusCost_<version>.json` file in [src/open-data/dataset-metadata](../../../open-data/dataset-metadata/) for each Cost Management cost export version. | ||
| 2. Create a `FinOpsHubs_<dataset>_<schema-version>.json` file in [src/open-data/dataset-metadata](../../../open-data/dataset-metadata/) for each FinOps hub managed dataset schema version. | ||
| 3. Mirror the schema details (columns, types, descriptions) from the matching Cost Management export or FinOps hubs schema so downstream consumers see consistent metadata. | ||
| 6. Update plugin skill files | ||
| 1. Refresh the FOCUS schema and function references in the following files so plugin guidance does not go stale: | ||
| - [src/templates/agent-skills/finops-toolkit/references/finops-hubs.md](../../agent-skills/finops-toolkit/references/finops-hubs.md) | ||
| - [src/templates/agent-skills/finops-toolkit/references/finops-hubs-deployment.md](../../agent-skills/finops-toolkit/references/finops-hubs-deployment.md) | ||
| - [src/templates/agent-skills/azure-cost-management/references/azure-cost-exports.md](../../agent-skills/azure-cost-management/references/azure-cost-exports.md) | ||
| - [src/templates/claude-plugin/agents/ftk-database-query.md](../../claude-plugin/agents/ftk-database-query.md) | ||
| - [src/templates/claude-plugin/output-styles/ftk-output-style.md](../../claude-plugin/output-styles/ftk-output-style.md) | ||
| 7. Update changelog | ||
| 1. Add an entry under the next version in [docs-mslearn/toolkit/changelog.md](../../../../docs-mslearn/toolkit/changelog.md) describing the new FOCUS version support and any preview status. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forward-dated content in a published Learn page: this adds a
15+ -> v1_4 -> 1.4row (andv1_4/Costs_v1_4examples on line 55) before 1.4 support has shipped. If docs-mslearn publishes on merge rather than gated to the 1.4 release, this page would publicly state 1.4 is supported ahead of release. Consider holding thev1_4row/examples for a later phase, or confirm the publish cadence makes this safe.