fix: remove floating-ui from headless components bundle#36344
Open
mainframev wants to merge 1 commit into
Open
fix: remove floating-ui from headless components bundle#36344mainframev wants to merge 1 commit into
mainframev wants to merge 1 commit into
Conversation
|
Pull request demo site: URL |
mainframev
force-pushed
the
fix/headless-positioning-floating-ui-leak
branch
from
fdb5b2c to
7e8a4a8
Compare
📊 Bundle size report✅ No changes found |
dmytrokirpa
reviewed
Jun 24, 2026
dmytrokirpa
left a comment
dmytrokirpa
left a comment
Contributor
There was a problem hiding this comment.
Let's hold off on this PR for now, since it doesn't seem to affect bundle size -#36344 (comment)
The PR changes don't seem to change much - @floating-ui will still be in node_modules since we still import types from react-positioning, but the fact that @floating-ui shouldn't end up in the headless or its consumers bundle. If that's the case, I'd like a repro so we can properly investigate the potential issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fluentui/react-headless-components-previewpositions via native CSS anchor positioning and should not bundle@floating-ui/dom. It still pulled it in transitively through a single runtime import ofresolvePositioningShorthandfrom@fluentui/react-positioning, whose barrel eagerly loadsusePositioning→@floating-ui/dom.