Avoid per-result byte array allocation in EvaluateFilter#1571
Merged
hailangx merged 2 commits intohaixu/vector-filter-postprocessingfrom Feb 20, 2026
Merged
Avoid per-result byte array allocation in EvaluateFilter#1571hailangx merged 2 commits intohaixu/vector-filter-postprocessingfrom
hailangx merged 2 commits intohaixu/vector-filter-postprocessingfrom
Conversation
… with ParseValue Co-authored-by: hailangx <3389245+hailangx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on post-filter support for VSIM vector search results
Avoid per-result byte array allocation in EvaluateFilter
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EvaluateFilterwas callingattributeJson.ToArray()on every filtered VSIM result before passing toJsonDocument.Parse, allocating a newbyte[]per result on the hot path.Change
Replace the allocating parse with a zero-copy parse using
Utf8JsonReader+JsonDocument.ParseValue:Utf8JsonReaderacceptsReadOnlySpan<byte>directly, soParseValueparses in-place without materializing an intermediate array, eliminating the per-result GC allocation on the VSIM post-filter path.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.