Skip to content

Remove stale crypto/ecdsa/badlinkname.go #2379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qmuntal merged 2 commits into from
Jun 18, 2026
+1 −28
Merged

Remove stale crypto/ecdsa/badlinkname.go #2379

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f8724a
remove stale ecdsa/badlinkname.go
qmuntal Jun 18, 2026
c895b3f
Merge remote-tracking branch 'origin/microsoft/main' into dev/qmuntal…
Copilot Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 1 addition & 28 deletions patches/0002-Add-crypto-backends.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ Subject: [PATCH] Add crypto backends
src/crypto/ecdh/ecdh_test.go | 19 +-
src/crypto/ecdh/nist.go | 54 ++--
src/crypto/ecdh/x25519.go | 51 ++++
src/crypto/ecdsa/badlinkname.go | 19 ++
src/crypto/ecdsa/boring.go | 19 +-
src/crypto/ecdsa/ecdsa.go | 19 +-
src/crypto/ecdsa/notboring.go | 8 +-
Expand Down Expand Up @@ -138,11 +137,10 @@ Subject: [PATCH] Add crypto backends
src/os/exec/exec_test.go | 9 +
src/runtime/runtime_boring.go | 5 +
src/syscall/syscall_windows.go | 3 +
134 files changed, 2528 insertions(+), 378 deletions(-)
133 files changed, 2509 insertions(+), 378 deletions(-)
create mode 100644 src/cmd/go/systemcrypto_test.go
create mode 100644 src/crypto/dsa/boring.go
create mode 100644 src/crypto/dsa/notboring.go
create mode 100644 src/crypto/ecdsa/badlinkname.go
create mode 100644 src/crypto/ed25519/boring.go
create mode 100644 src/crypto/ed25519/notboring.go
create mode 100644 src/crypto/systemcrypto_nocgo_linux.go
Expand Down Expand Up @@ -2199,31 +2197,6 @@ index 21a921aa12d44d..075b2f679d2238 100644
out := make([]byte, x25519SharedSecretSize)
x25519ScalarMult(out, local.privateKey, remote.publicKey)
if isZero(out) {
diff --git a/src/crypto/ecdsa/badlinkname.go b/src/crypto/ecdsa/badlinkname.go
new file mode 100644
index 00000000000000..168efdb820c85b
--- /dev/null
+++ b/src/crypto/ecdsa/badlinkname.go
@@ -0,0 +1,19 @@
+// Copyright 2025 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+//go:build goexperiment.systemcrypto
+
+package ecdsa
+
+import _ "unsafe"
+
+// The symbols below are pulled by some crypto backend in the Microsoft build of Go compiler.
+// We provide a push linkname here, to keep them accessible with pull linknames.
+
+//go:linkname encodeSignature
+//go:linkname parseSignature
+
+// This supplements other linknames that are already added by
+// https://github.com/golang/go/commit/41aab30bd260297ad8ddad47e98fdf8390a9a67e
+// See that commit for more information.
diff --git a/src/crypto/ecdsa/boring.go b/src/crypto/ecdsa/boring.go
index 275c60b4de49eb..a5b6ae9dc90505 100644
--- a/src/crypto/ecdsa/boring.go
Expand Down
Loading