Open
Conversation
Contributor
|
@bweggersen I wanted to acknowledge that I saw your PR, but unfortunately it may be a bit before I can get to it (I want to add tests to this code base too before I add/accept new features). |
Member
Author
|
I understand. Thanks for letting me know.
…On Fri, 29 Mar 2019 at 01:48, Dylan Smith ***@***.***> wrote:
@bweggersen <https://github.com/bweggersen> I wanted to acknowledge that
I saw your PR, but unfortunately it may be a bit before I can get to it (I
want to add tests to this code base too before I add/accept new features).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACgzt6kYPlzLFW4GF7rNWGABPmZOl0vUks5vbWL1gaJpZM4cDPbK>
.
|
|
@bweggersen , to confirm, this will include all files in globs specified like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodir: trueinglobOptionsallows glob to include symlinks in the return list, as they are treated as directories..tgzfile, I've setnoDirRecurse: true, which means node-tar will only include the files explicitly referenced in thefileslist. Directories (i.e. symlinks) will then only be included as empty directories. Thefileslist includes a complete list of all the files to be archived, so this option shouldn't create any regressions.preservePaths: trueto output symlinks correctly ontar.extract.