Fix built-in type exception throwing to comply with Core Guidelines E.14

[Copilot]

The Reader constructor in src/ifc-reader/reader.cxx was throwing a built-in type (string literal) which violates C++ Core Guidelines E.14:

// Before - violates Core Guidelines E.14
if (not ifc.header())
    throw "file not found";  // ❌ Throwing built-in type

// After - complies with Core Guidelines E.14
if (not ifc.header())
    throw InputIfc::IfcHeaderNotAvailable{};  // ✅ Proper exception type

Changes Made

1. Added new exception type IfcHeaderNotAvailable in include/ifc/file.hxx

   • Follows the same pattern as other exception types like IllFormedPartitionName
   • Placed within InputIfc struct to indicate the context
   • No parameters required since the Reader constructor doesn't have access to path information

2. Updated Reader constructor to use the proper exception type instead of throwing a string literal

Context

The Reader constructor checks if ifc.header() returns a valid pointer. The header is only initialized when validate() is called on the InputIfc object. The fix creates a proper exception type that accurately describes the error condition (header not available) without requiring additional parameters that aren't available in the constructor context.

Verification

• ✅ Code builds successfully
• ✅ No other built-in type exceptions found in codebase
• ✅ Exception type compiles and works correctly
• ✅ Code formatting applied with clang-format

This change ensures full compliance with C++ Core Guidelines E.14: "Don't throw built-in types".

Fixes #33.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• esm.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[gdr-at-ms]

1. Rename the new exception to MissingIfcHeader
2. Find all the places where the constructor is called

[Copilot]

1. Rename the new exception to MissingIfcHeader
2. Find all the places where the constructor is called

1. Done - renamed exception to MissingIfcHeader in 69f824b
2. Found all places where the Reader constructor is called:
   • src/ifc-printer/main.cxx:116: ifc::Reader reader(file);
   • test/basic.cxx:180: return Reader{ *ifc };

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• esm.ubuntu.com
  • Triggering command: /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

[gdr-at-ms]

Don't apply clang-format

[Copilot]

Don't apply clang-format

Understood - I will not apply clang-format to the code. The current changes will remain as-is without automatic formatting.

[gdr-at-ms]

Are you still working on the draft?