Skip to content

Conversation

@ecraig12345
Copy link
Member

@ecraig12345 ecraig12345 commented Sep 11, 2024

Since lage is bundled, dependencies should be pinned to ensure that direct dep updates are explicit, not implicit due to lock file changes. (The implicit update issue unfortunately still exists for sub-dependencies, but pinning direct deps reduces it.) However, the pinned deps are unfortunate for anyone consuming the sub-packages directly.

This PR adds a beachball pre-publish hook to unpin the deps just before publishing.

Test with: yarn release --no-push -n faketoken

@ecraig12345
Copy link
Member Author

ecraig12345 commented Sep 12, 2024

Pinning was added in #712, so presumably the implicit dep update bug that prompted pinning happened in Dec. 2023 or earlier (and Feb. 2023 or later, after bundled lage v2 was promoted to latest in #572), but I can't find anything mentioning it in the commit history or issues...

@ecraig12345 ecraig12345 force-pushed the prepublish-unpin branch 5 times, most recently from 423e2b5 to c445e0a Compare January 23, 2026 12:42
@ecraig12345 ecraig12345 merged commit 092607a into microsoft:master Jan 24, 2026
10 checks passed
@ecraig12345 ecraig12345 deleted the prepublish-unpin branch January 24, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant