This repository was archived by the owner on Feb 12, 2021. It is now read-only.
Fix deadlock in event handler for thumbnail tap - #1
Open
anirudhsanthiar wants to merge 1 commit into
Open
Conversation
Lines 114-116 of LensBlurApp/Pages/GalleryPage.xaml.cs say var task = photo.File.OpenReadAsync().AsTask(); task.Wait(); The Wait on line 114 will block the UI thread. The thread can proceed only when the Task returned by OpenReadAsync().AsTask() competes. However, the continuation completing this task will be posted to the captured synchronization context from the UI thread, which is blocked, and will never run. This results in deadlock. This patch replaces task.Wait() by await task, and marks the event handler async. Avoiding the blocking wait fixes the deadlock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lines 114-116 of LensBlurApp/Pages/GalleryPage.xaml.cs say
var task = photo.File.OpenReadAsync().AsTask();
task.Wait();
The Wait on line 114 will block the UI thread. The thread can proceed
only when the Task returned by OpenReadAsync().AsTask() competes.
However, the continuation completing this task will
be posted to the captured synchronization context from the UI thread,
which is blocked, and will never run. This results in deadlock.
This patch replaces task.Wait() by await task, and marks the event
handler async. Avoiding the blocking wait fixes the deadlock.