Skip to content

Update Cybereason driver to use structural pattern matching#880

Open
FlorianBracq wants to merge 27 commits intomicrosoft:mainfrom
FlorianBracq:florian/cr-structural-pattern-matching
Open

Update Cybereason driver to use structural pattern matching#880
FlorianBracq wants to merge 27 commits intomicrosoft:mainfrom
FlorianBracq:florian/cr-structural-pattern-matching

Conversation

@FlorianBracq
Copy link
Collaborator

Starting with python 3.10, structural pattern matching was introduced through PEP 636 and it helps hanlding (among many things) dictionaries/JSON responses from API.

The goal of this PR is to update the Cybereason driver to leverage this new feature and ensure more corner cases of the Cybereason API are covered.
Changes include:

  • Improve support of timeout errors by adding a retry
  • improve parsing of (what appears to be a) successful response
  • improve handling of HTTP 429 (too many requests)
  • Update docstring
  • Change exceptions to leverage msticpy's exceptions as much as possible

Another change is in query_provider_connections_mixin to update the logging of exception handling:

  • Add more details for a global exception
  • Add specific logging for MsticpyDataQueryError .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant