De-flake HTTP E2E: replace rate-limited GitHub API call with httpbingo.org#284
Merged
Conversation
…o.org The 06_http_and_ssrf E2E test's "JSON API with vars and loop" case fetched https://api.github.com/repos/microsoft/duroxide/commits, whose rate limit makes the request fail intermittently in CI ("GitHub API fetch status = failed"), flaking the whole E2E job. Point it at https://httpbingo.org/get instead — the same non-rate-limited endpoint the rest of this file already uses — so the case is deterministic. Both hosts are already in the http-allow-test-domains allowlist, so no code change is needed.
pinodeca
approved these changes
Jul 2, 2026
pinodeca
left a comment
pinodeca
left a comment
Contributor
There was a problem hiding this comment.
From Opus 4.8:
Minor nit (non-blocking)
httpbingo.org runs go-httpbin, which returns args and headers as arrays of strings (multi-valued), unlike the original httpbin.org which returns scalars. So:
body->'args'->>'source' -- stores ["pg_durable"] (not pg_durable)
body->'headers'->>'User-Agent' -- stores ["pg_durable-test"] (not pg_durable-test)The test still passes because it only asserts result_count > 0, and url (the ON CONFLICT key) is a scalar. But the source / user_agent columns—and the final display SELECT—will contain JSON-array-serialized text rather than clean scalars. If you want the displayed values to look right, index the first element:
body->'args'->'source'->>0,
body->'headers'->'User-Agent'->>0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tests/e2e/sql/06_http_and_ssrf.sql's "JSON API with vars and loop" case fetchedhttps://api.github.com/repos/microsoft/duroxide/commits. GitHub's API rate limit makes that request fail intermittently in CI (TEST FAILED: GitHub API fetch status = failed), flaking the whole E2E job.Change
Point the case at
https://httpbingo.org/get— the same non-rate-limited HTTP test endpoint the rest of this file already uses — so it is deterministic. Both hosts are already in thehttp-allow-test-domainsallowlist, so no code change is needed.Test
./scripts/test-e2e-local.sh 06_http_and_ssrfpasses.