Fix asctime formatting, don't print uninitialized buffer's content (issue #203)

[tarasko]

Closes #203
Correctly format and print LogRecord.asctime field

Please merge this PR or #209
where %f support in datefmt was also added.

import time
import picologging as logging

logging.basicConfig(format="%(levelname)s - %(asctime)s - %(name)s - %(module)s - %(message)s")
logger = logging.getLogger()
logger.setLevel(logging.INFO)

if __name__ == '__main__':
    for i in range(5):
        time.sleep(0.4)
        logger.info("Hello world! %d", i)

INFO - 2024-07-23 04:35:30,285 - root - <unknown> - Hello world! 0
INFO - 2024-07-23 04:35:30,685 - root - <unknown> - Hello world! 1
INFO - 2024-07-23 04:35:31,085 - root - <unknown> - Hello world! 2
INFO - 2024-07-23 04:35:31,485 - root - <unknown> - Hello world! 3
INFO - 2024-07-23 04:35:31,886 - root - <unknown> - Hello world! 4

[NoAnyLove]

According to https://docs.python.org/3/library/logging.html#logrecord-attributes, the default date format should have 3 digits instead of 6 for the millisecond portion of the time.

[tarasko]

According to https://docs.python.org/3/library/logging.html#logrecord-attributes, the default date format should have 3 digits instead of 6 for the millisecond portion of the time.

Fixed

[river-walras]

According to https://docs.python.org/3/library/logging.html#logrecord-attributes, the default date format should have 3 digits instead of 6 for the millisecond portion of the time.

Fixed

import picologging as logging

logging.basicConfig(format="%(levelname)s - %(asctime)s - %(name)s - %(module)s - %(message)s", datefmt="%F %T.%f")
logger = logging.getLogger()
logger.setLevel(logging.INFO)

if __name__ == '__main__':
    for i in range(5):
        logger.info("Hello world! %d", i)

I ran this code and the return is still the same:

INFO - 2024-08-01 04:24:57.%f - root - <unknown> - Hello world! 0
INFO - 2024-08-01 04:24:57.%f - root - <unknown> - Hello world! 1
INFO - 2024-08-01 04:24:57.%f - root - <unknown> - Hello world! 2
INFO - 2024-08-01 04:24:57.%f - root - <unknown> - Hello world! 3
INFO - 2024-08-01 04:24:57.%f - root - <unknown> - Hello world! 4

[tarasko]

According to https://docs.python.org/3/library/logging.html#logrecord-attributes, the default date format should have 3 digits instead of 6 for the millisecond portion of the time.

Fixed

import picologging as logging

logging.basicConfig(format="%(levelname)s - %(asctime)s - %(name)s - %(module)s - %(message)s", datefmt="%F %T.%f")
logger = logging.getLogger()
logger.setLevel(logging.INFO)

if __name__ == '__main__':
    for i in range(5):
        logger.info("Hello world! %d", i)

I ran this code and the return is still the same:

INFO - 2024-08-01 04:24:57.%f - root - <unknown> - Hello world! 0
INFO - 2024-08-01 04:24:57.%f - root - <unknown> - Hello world! 1
INFO - 2024-08-01 04:24:57.%f - root - <unknown> - Hello world! 2
INFO - 2024-08-01 04:24:57.%f - root - <unknown> - Hello world! 3
INFO - 2024-08-01 04:24:57.%f - root - <unknown> - Hello world! 4

This PR only fixes default asctime formatting (without datefmt argument). By default only milliseconds are supposed to be printed.
If you would like to try out %f support please check a different PR
#209

[tonybaloney]

Thanks @tarasko. Sorry I didn't respond earlier.

This needs a regression test first on main. I'll do that now

[tonybaloney]

I prefer this implementation. thanks for submitting. Pushing a regression test to the PR then will be merging once everything passes

[river-walras]

Closes #203 Correctly format and print LogRecord.asctime field

Please merge this PR or #209 where %f support in datefmt was also added.

import time
import picologging as logging

logging.basicConfig(format="%(levelname)s - %(asctime)s - %(name)s - %(module)s - %(message)s")
logger = logging.getLogger()
logger.setLevel(logging.INFO)

if __name__ == '__main__':
    for i in range(5):
        time.sleep(0.4)
        logger.info("Hello world! %d", i)

INFO - 2024-07-23 04:35:30,285 - root - <unknown> - Hello world! 0
INFO - 2024-07-23 04:35:30,685 - root - <unknown> - Hello world! 1
INFO - 2024-07-23 04:35:31,085 - root - <unknown> - Hello world! 2
INFO - 2024-07-23 04:35:31,485 - root - <unknown> - Hello world! 3
INFO - 2024-07-23 04:35:31,886 - root - <unknown> - Hello world! 4

Closes #203 Correctly format and print LogRecord.asctime field

Please merge this PR or #209 where %f support in datefmt was also added.

import time
import picologging as logging

logging.basicConfig(format="%(levelname)s - %(asctime)s - %(name)s - %(module)s - %(message)s")
logger = logging.getLogger()
logger.setLevel(logging.INFO)

if __name__ == '__main__':
    for i in range(5):
        time.sleep(0.4)
        logger.info("Hello world! %d", i)

INFO - 2024-07-23 04:35:30,285 - root - <unknown> - Hello world! 0
INFO - 2024-07-23 04:35:30,685 - root - <unknown> - Hello world! 1
INFO - 2024-07-23 04:35:31,085 - root - <unknown> - Hello world! 2
INFO - 2024-07-23 04:35:31,485 - root - <unknown> - Hello world! 3
INFO - 2024-07-23 04:35:31,886 - root - <unknown> - Hello world! 4

I ran this code with picologging==0.9.3, still get

INFO - pQC�c,427881311 - root - <unknown> - Hello world! 0
INFO - ,427881711 - root - <unknown> - Hello world! 1
INFO - ,427882111 - root - <unknown> - Hello world! 2
INFO - ,427882512 - root - <unknown> - Hello world! 3
INFO - ,427882912 - root - <unknown> - Hello world! 4