devops(docker): split browser layers and use zstd compression for faster pulls#41232
devops(docker): split browser layers and use zstd compression for faster pulls#41232KRRT7 wants to merge 11 commits into
Conversation
…n for faster pulls (microsoft#40702)" (microsoft#41081) This reverts commit 67930e8.
|
@dgozman ^^ |
|
@dcrousso I tagged them so that they'd trigger the GHAs, I have no idea what you guys saw, I've been using it on my linux / macOS machines with no issues, I'd need to trigger the issue for me to be able to debug edit: sorry, could've been clearer about my intentions |
|
as per #41081 (comment) without the logs, best I can hope for is for it to get triggered in your CI for me to be able to analyze. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
hmm, ok, I think I know what's up. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@KRRT7 Seems to be still failing. |
|
@dgozman sorry for the delay, should be good now, I tried it on my MacOS and via dockers and now everything passes for the issues I found |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| rm -rf ~/.npm/ && \ | ||
| chmod -R 777 /ms-playwright | ||
| # Keep the full browser registry writable for later npm ci runs, including .links. | ||
| chmod -R a+rwx /ms-playwright && \ |
There was a problem hiding this comment.
Won't this touch the whole /ms-playwright, including previously installed browsers, and make the last layer very large? Perhaps move this to the first layer instead?
| @@ -11,7 +11,6 @@ ENV LC_ALL=C.UTF-8 | |||
| # === INSTALL Node.js === | |||
There was a problem hiding this comment.
Note we also have Dockerfile.resolute now.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
geez, dunno why it fails on there but not locally, let me take another look |
|
I refactored the shared browser install logic into utils/docker/install_browsers.sh so jammy/noble/resolute stay in sync going forward while preserving separate Docker RUN layers for chromium/firefox/webkit. |
dgozman
left a comment
dgozman
left a comment
There was a problem hiding this comment.
I think we went backwards, from an almost-working solution to a larger refactoring that is less likely to land.
This reverts commit 59098d2.
Test results for "MCP"1 failed 7353 passed, 1122 skipped Merge workflow run. |
Test results for "tests 1"3 flaky39599 passed, 744 skipped Merge workflow run. |
dgozman
changed the title
|
seems like the test is just flaky, luckily for me. |
3 participants
This reverts commit 67930e8, reapplying #40702.
Closes #40701.