Skip to content

chore(chromium): reenable RenderDocument again#41303

Merged
dgozman merged 1 commit into
microsoft:mainfrom
dgozman:chore-render-document-v3
Jun 25, 2026
Merged

chore(chromium): reenable RenderDocument again#41303
dgozman merged 1 commit into
microsoft:mainfrom
dgozman:chore-render-document-v3

Conversation

@dgozman

@dgozman dgozman commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Note: this also deprecates Coverage.startJSCoverage.resetOnNavigation option, since it's not compatible with the new architecture.

Closes #37714.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@dgozman dgozman added the CQ1 label Jun 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests others"

7 failed
❌ [electron-page] › page/page-autowaiting-no-hang.spec.ts:41 › assigning location to about:blank @electron-macos-latest
❌ [chromium-library] › library/browsercontext-page-event.spec.ts:160 › should work with Shift-clicking @frozen-time-library-chromium-linux
❌ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking @frozen-time-library-chromium-linux
❌ [chromium-library] › library/chromium/js-coverage.spec.ts:66 › should report scripts across navigations when disabled @frozen-time-library-chromium-linux
❌ [chromium-library] › library/browsercontext-page-event.spec.ts:160 › should work with Shift-clicking @realtime-time-library-chromium-linux
❌ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking @realtime-time-library-chromium-linux
❌ [chromium-library] › library/chromium/js-coverage.spec.ts:66 › should report scripts across navigations when disabled @realtime-time-library-chromium-linux

12 flaky ⚠️ [electron-page] › page/page-autowaiting-no-hang.spec.ts:41 › assigning location to about:blank `@electron-ubuntu-latest`
⚠️ [electron-page] › page/page-evaluate.spec.ts:564 › should not throw an error when evaluation does a synchronous navigation and returns an object `@electron-ubuntu-latest`
⚠️ [electron-page] › page/page-evaluate.spec.ts:573 › should not throw an error when evaluation does a synchronous navigation and returns undefined `@electron-ubuntu-latest`
⚠️ [electron-page] › page/page-route.spec.ts:1027 › route.fulfill should throw if called twice `@electron-ubuntu-latest`
⚠️ [electron-page] › page/page-evaluate.spec.ts:179 › should throw when evaluation triggers reload `@electron-macos-latest`
⚠️ [electron-page] › page/page-evaluate.spec.ts:564 › should not throw an error when evaluation does a synchronous navigation and returns an object `@electron-macos-latest`
⚠️ [electron-page] › page/page-evaluate.spec.ts:573 › should not throw an error when evaluation does a synchronous navigation and returns undefined `@electron-macos-latest`
⚠️ [electron-page] › page/page-route.spec.ts:1027 › route.fulfill should throw if called twice `@electron-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:211 › should intercept service worker requests (main and within) `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:275 › screencast › should capture navigation `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:645 › screencast › should capture full viewport `@frozen-time-library-chromium-linux`
⚠️ [electron-page] › page/page-autowaiting-no-hang.spec.ts:41 › assigning location to about:blank `@electron-windows-latest`

19968 passed, 647 skipped


Merge workflow run.

@github-actions

This comment has been minimized.

@dgozman dgozman force-pushed the chore-render-document-v3 branch from 30a12a3 to 5f98fca Compare June 25, 2026 09:44
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@dgozman dgozman force-pushed the chore-render-document-v3 branch from 5f98fca to 33494a7 Compare June 25, 2026 13:35
@dgozman dgozman added CQ1 and removed CQ1 labels Jun 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chrome] › mcp/http.spec.ts:349 › client should receive list roots request @mcp-macos-latest-chrome
❌ [chrome] › mcp/http.spec.ts:349 › client should receive list roots request @mcp-ubuntu-latest-chrome
❌ [firefox] › mcp/http.spec.ts:349 › client should receive list roots request @mcp-macos-latest-firefox

7377 passed, 1122 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 failed
❌ [chromium-library] › library/browsercontext-add-init-script.spec.ts:28 › should work without navigation, after all bindings @chromium-ubuntu-22.04-arm-node20
❌ [chromium-library] › library/browsercontext-expose-function.spec.ts:77 › should be callable from-inside addInitScript @chromium-ubuntu-22.04-arm-node20

6 flaky ⚠️ [chromium-library] › library/video.spec.ts:717 › screencast › should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:177 › serviceWorker(), and fromServiceWorker() work `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:645 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:827 › should update state on subsequent run `@ubuntu-latest-node20`

49046 passed, 1142 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

4 failed
❌ [webkit-library] › library/client-certificates.spec.ts:346 › browser › should not intercept TLS for origins without a client certificate @webkit-windows-latest
❌ [webkit-library] › library/har.spec.ts:688 › should return security details directly from response @webkit-windows-latest
❌ [android-native] › android/device.spec.ts:56 › androidDevice.fill
❌ [android-native] › android/webview.spec.ts:44 › should navigate page externally

47 flaky ⚠️ [electron-page] › page/page-autowaiting-no-hang.spec.ts:41 › assigning location to about:blank `@electron-ubuntu-latest`
⚠️ [electron-page] › page/page-autowaiting-no-hang.spec.ts:46 › assigning location to about:blank after non-about:blank `@electron-ubuntu-latest`
⚠️ [electron-page] › page/page-evaluate.spec.ts:179 › should throw when evaluation triggers reload `@electron-ubuntu-latest`
⚠️ [electron-page] › page/page-evaluate.spec.ts:564 › should not throw an error when evaluation does a synchronous navigation and returns an object `@electron-ubuntu-latest`
⚠️ [electron-page] › page/page-evaluate.spec.ts:573 › should not throw an error when evaluation does a synchronous navigation and returns undefined `@electron-ubuntu-latest`
⚠️ [electron-page] › page/page-route.spec.ts:1027 › route.fulfill should throw if called twice `@electron-ubuntu-latest`
⚠️ [electron-page] › page/page-autowaiting-no-hang.spec.ts:46 › assigning location to about:blank after non-about:blank `@electron-macos-latest`
⚠️ [electron-page] › page/page-evaluate.spec.ts:564 › should not throw an error when evaluation does a synchronous navigation and returns an object `@electron-macos-latest`
⚠️ [electron-page] › page/page-evaluate.spec.ts:573 › should not throw an error when evaluation does a synchronous navigation and returns undefined `@electron-macos-latest`
⚠️ [electron-page] › page/page-route.spec.ts:1027 › route.fulfill should throw if called twice `@electron-macos-latest`
⚠️ [chromium-page] › page/page-screenshot.spec.ts:429 › page screenshot › should take fullPage screenshots during navigation `@tracing-chromium`
⚠️ [chromium-library] › library/signals.spec.ts:25 › should close the browser when the node process closes `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/video.spec.ts:456 › screencast › should be 800x600 with null viewport `@msedge-dev-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:177 › serviceWorker(), and fromServiceWorker() work `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:434 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/video.spec.ts:456 › screencast › should be 800x600 with null viewport `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/video.spec.ts:337 › screencast › should work for popups `@msedge-windows-latest`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:189 › launchServer › should ignore page.pause when headed `@chromium-macos-15-large`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:371 › should produce network events, routing, and annotations for Service Worker `@chromium-macos-15-large`
⚠️ [chromium-library] › library/heap.spec.ts:304 › cycle handles `@chromium-macos-15-large`
⚠️ [chromium-library] › library/video.spec.ts:680 › screencast › should capture full viewport on hidpi `@chromium-macos-15-large`
⚠️ [chromium-library] › library/screenshot.spec.ts:213 › page screenshot › should not hang when event loop is blocked `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/screenshot.spec.ts:213 › page screenshot › should not hang when event loop is blocked `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:645 › screencast › should capture full viewport `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:680 › screencast › should capture full viewport on hidpi `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:456 › screencast › should be 800x600 with null viewport `@chrome-windows-latest`
⚠️ [chromium-library] › library/video.spec.ts:456 › screencast › should be 800x600 with null viewport `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:141 › launchServer › should be able to reconnect to a browser `@chrome-macos-latest`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:161 › launchServer › should not crash on malformed json frame `@chrome-macos-latest`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:386 › launchServer › should reject waitForSelector when browser closes `@chrome-macos-latest`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:632 › launchServer › should properly disconnect when connection closes from the client side `@chrome-macos-latest`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:1117 › launchServer only › should be able to reconnect to a browser 12 times without warnings `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:371 › should produce network events, routing, and annotations for Service Worker `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:434 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-macos-latest`
⚠️ [chromium-library] › library/video.spec.ts:456 › screencast › should be 800x600 with null viewport `@chrome-macos-latest`
⚠️ [chromium-library] › library/tracing.spec.ts:781 › should not emit after w/o before `@driver`
⚠️ [electron-page] › page/page-autowaiting-no-hang.spec.ts:41 › assigning location to about:blank `@electron-windows-latest`
⚠️ [electron-page] › page/page-evaluate.spec.ts:573 › should not throw an error when evaluation does a synchronous navigation and returns undefined `@electron-windows-latest`
⚠️ [firefox-library] › library/video.spec.ts:371 › screencast › should scale frames down to the requested size `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:163 › should propagate default viewport to the page `@firefox-macos-15-large`
⚠️ [firefox-library] › library/defaultbrowsercontext-2.spec.ts:180 › should have passed URL when launching with ignoreDefaultArgs: true `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:170 › should make a copy of default viewport `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/heap.spec.ts:223 › should not leak workers `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/screenshot.spec.ts:213 › page screenshot › should not hang when event loop is blocked `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:792 › run-server › should upload a folder `@webkit-macos-15-xlarge`
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:221 › post data › should amend post data `@webkit-macos-15-xlarge`
⚠️ [android-page] › page/page-request-fulfill.spec.ts:81 › should fulfill with unuassigned status codes

104885 passed, 4404 skipped


Merge workflow run.

@dgozman dgozman merged commit 966ed43 into microsoft:main Jun 25, 2026
73 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[internal] re-enable RenderDocument

3 participants