feat(webview): track same-document navigations#41414
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
In https://github.com/microsoft/playwright/pull/41409/changes you are using window.naviation. If it exists, do we need to patch the methods or listeners will work? |
|
it only uses we have to swizzle this is not necessary for the Navigation API because all methods that modify the current URL will dispatch a |
Test results for "tests 2"1 fatal errors, not part of any test 41 flaky99773 passed, 4308 skipped Merge workflow run. |
69819e5 to
355a104
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
`Page.navigatedWithinDocument` does not exist in the upstream WebKit inspector protocol instead, use JS `"popstate"`, `"hashchange"`, and `"currententrychange"` events to track that note that this involves leveraging the existing `console.debug()` communication method
355a104 to
a41a0e9
Compare
|
im going to investigate the test timeouts separately |
Test results for "MCP"7380 passed, 1122 skipped Merge workflow run. |
Test results for "tests 1"3 failed 6 flaky48923 passed, 1142 skipped Merge workflow run. |
|
im gonna investigate the issue with |
|
test timeout fixed in #41416 |
Page.navigatedWithinDocumentdoes not exist in the upstream WebKit inspector protocolinstead, use JS
"popstate","hashchange", and"currententrychange"events to track thatnote that this involves leveraging the existing
console.debug()communication method