Add support for formatting pane new model interfaces #49
Conversation
ShereinDabbah
commented
Jun 22, 2022
ShereinDabbah
commented
- bump to version 5.0.0
- Add formatting pane model interfaces
- Separate visuals and formatting pane interfaces into two files
Export powerbi module Update changelog
This reverts commit 9e00af2.
ShereinDabbah
requested review from
AsafMozes,
AviSander,
Yarovinsky,
anitamayorov and
uve
|
Please wait for api 4.8 before completing this one. |
src/formatting-model-api.d.ts
Outdated
|
|
||
| export interface FormattingModelMessageAction { | ||
| key: string; | ||
| fn: () => void; |
There was a problem hiding this comment.
what does fn() do? does the CV pass the code into the host?
There was a problem hiding this comment.
I dont know how it exactly works, But I see that yes it run some code in our side in some html file in front end.
Should I delete it ?
There was a problem hiding this comment.
if this is code that the visual provides then we should remove it.
| topLevelToggle?: EnabledSlice; | ||
| groups: (FormattingGroup | FormattingGroupPlaceholder)[]; | ||
| /** This contains the list of descriptors for revert to default, note the descriptors of all the slices ever possible in the card must be added */ | ||
| revertToDefaultDescriptors?: FormattingDescriptor[]; |
There was a problem hiding this comment.
hey can you explain what the purpose of this is?
There was a problem hiding this comment.
revertToDefaultDescriptors is the list of all formatting properties descriptors (descriptor is objectName and propertyName - the same as in capabilites) in this formatting card that will be reverted/reset their values to their default values when we click on Reset to default option which appears in each formatting card.
revertToDefaultDescriptors is required if we want to use the Reset to default option and reset all of the properties in card in one click
| * signal action is taken. E.g., for an Analytics Pane forecast, the forecast parameter values shouldn't be | ||
| * saved to the visual until the Apply button is clicked. Note that this applies to all slices in the group. | ||
| */ | ||
| delaySaveSlices?: boolean; |
There was a problem hiding this comment.
I dont know exactly what is the use of this
src/formatting-model-api.d.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * Handles resolving the type of placeholder that's expected to be return. |
src/formatting-model-api.d.ts
Outdated
|
|
||
| interface Slider extends NumUpDown { } | ||
|
|
||
| // ideally we would set type here to number, but the old formatting pane always converts enum members to string |
