Feature/support center audio by kostapetan · Pull Request #102 · microsoft/project-oagents

kostapetan · 2025-01-30T11:59:23Z

No description provided.

Copilot

Copilot reviewed 120 out of 134 changed files in this pull request and generated 1 comment.

Files not reviewed (14)

OAgents.sln: Language not supported
samples/support-center/.gitignore: Language not supported
samples/support-center/SupportCenter.ApiService/Agents/Dispatcher/Dispatcher.cs: Evaluated as low risk
samples/support-center/SupportCenter.ApiService/Agents/Invoice/Invoice.cs: Evaluated as low risk
samples/support-center/SupportCenter.ApiService/Agents/QnA/QnA.cs: Evaluated as low risk
samples/support-center/SupportCenter.ApiService/Agents/Conversation/Conversation.cs: Evaluated as low risk
samples/support-center/SupportCenter.ApiService/Agents/CustomerInfo/CustomerInfo.cs: Evaluated as low risk
samples/support-center/SupportCenter.ApiService/Agents/Discount/Discount.cs: Evaluated as low risk
samples/support-center/SupportCenter.ApiService/Agents/Conversation/ConversationPrompts.cs: Evaluated as low risk
samples/support-center/SupportCenter.ApiService/Agents/Invoice/InvoiceState.cs: Evaluated as low risk
samples/support-center/SupportCenter.ApiService/Agents/Dispatcher/DispatcherPrompts.cs: Evaluated as low risk
samples/support-center/SupportCenter.ApiService/Agents/QnA/QnAPrompts.cs: Evaluated as low risk
samples/support-center/SupportCenter.ApiService/Agents/CustomerInfo/CustomerInfoState.cs: Evaluated as low risk
samples/support-center/SupportCenter.ApiService/Agents/Invoice/InvoicePrompts.cs: Evaluated as low risk

Copilot · 2025-01-30T14:05:15Z

samples/support-center/SupportCenter.ApiService/Agents/Conversation/ConversationState.cs

@@ -0,0 +1,6 @@
+namespace SupportCenter.ApiService.Agents.Conversation;


There is an invisible character (Byte Order Mark) at the beginning of the file which may cause issues.

Suggested change

namespace SupportCenter.ApiService.Agents.Conversation;

namespace SupportCenter.ApiService.Agents.Conversation;

Copilot

Copilot reviewed 163 out of 178 changed files in this pull request and generated 3 comments.

Files not reviewed (15)

OAgents.sln: Language not supported
nuget.config: Language not supported
samples/gh-flow/src/Microsoft.AI.DevTeam.Dapr/Microsoft.AI.DevTeam.Dapr.csproj: Language not supported
samples/gh-flow/src/Microsoft.AI.DevTeam/Microsoft.AI.DevTeam.csproj: Language not supported
samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/ProductManager/PMPrompts.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam.Dapr/Agents/Architect/Architect.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/DeveloperLead/DeveloperLead.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/DeveloperLead/DevLeadPrompts.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/Developer/DeveloperPrompts.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/Architect/Architect.cs: Evaluated as low risk
samples/gh-flow/src/seed-memory/Program.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/Hubber.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam.Dapr/Program.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam.Dapr/Agents/ProductManager/ProductManager.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam.Dapr/Agents/Developer/Developer.cs: Evaluated as low risk

Comments suppressed due to low confidence (2)

samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/DeveloperLead.cs:8

The class declaration is missing the 'class' keyword.

public class DeveloperLead([PersistentState("state", "messages")] IPersistentState<AgentState<DeveloperLeadState>> state, IChatClient chatClient, ILogger<DeveloperLead> logger) : AiAgent<DeveloperLeadState>(state), ILeadDevelopers

samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/ProductManager.cs:62

The word 'frameowrk' is misspelled. It should be 'framework'.

Make prescriptive architecture, language, and frameowrk choices, do not provide a range of choices.

Copilot · 2025-02-05T11:11:25Z

samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/DeveloperLead.cs

+            var prompt = $$"""
+                            You are a Dev Lead for an application team, building the application described below. 
+                            Please break down the steps and modules required to develop the complete application, describe each step in detail.
+                            Make prescriptive architecture, language, and frameowrk choices, do not provide a range of choices. 


The word 'frameowrk' is misspelled. It should be 'framework'.

Suggested change

Make prescriptive architecture, language, and frameowrk choices, do not provide a range of choices.

Make prescriptive architecture, language, and framework choices, do not provide a range of choices.

Copilot · 2025-02-05T11:11:25Z

samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/Developer.cs

+                            Input: {input}
+                            {guidelines}
+                            """;
+            var result = await chatClient.CompleteAsync(prompt);


Add a null check for result.Message to ensure it is not null before accessing Text.

Suggested change

var result = await chatClient.CompleteAsync(prompt);

var result = await chatClient.CompleteAsync(prompt);

if (result.Message == null)

{

logger.LogError("Received null Message from chatClient.");

return default;

}

Copilot · 2025-02-05T11:11:26Z

samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/ProductManager.cs

-            var enhancedContext = await AddKnowledge(instruction, "waf",context);
-            return await CallFunction(PMSkills.Readme, enhancedContext);
+            var guidelines = await AddKnowledge(instruction, "waf");
+            var prompt = $$$""""


The triple dollar signs ($$$) used in the prompt string might be a typo. It should be double dollar signs ($$).

Suggested change

var prompt = $$$""""

var prompt = $$""""

Copilot

Copilot reviewed 200 out of 215 changed files in this pull request and generated 3 comments.

Files not reviewed (15)

OAgents.sln: Language not supported
nuget.config: Language not supported
samples/gh-flow/src/Microsoft.AI.DevTeam.Dapr/Microsoft.AI.DevTeam.Dapr.csproj: Language not supported
samples/gh-flow/src/Microsoft.AI.DevTeam/Microsoft.AI.DevTeam.csproj: Language not supported
samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/DeveloperLead/DevLeadPrompts.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/ProductManager/PMPrompts.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam.Dapr/Agents/Architect/Architect.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/Architect/Architect.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/DeveloperLead/DeveloperLead.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/Developer/DeveloperPrompts.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/Hubber.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam.Dapr/Program.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam.Dapr/Agents/ProductManager/ProductManager.cs: Evaluated as low risk
samples/gh-flow/src/seed-memory/Program.cs: Evaluated as low risk
samples/gh-flow/src/Microsoft.AI.DevTeam.Dapr/Agents/DeveloperLead/DeveloperLead.cs: Evaluated as low risk

Comments suppressed due to low confidence (2)

samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/DeveloperLead.cs:99

[nitpick] The error message could be more specific. Consider including the exception message.

logger.LogError(ex, "Error creating development plan");

samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/DeveloperLead.cs:50

Ensure that the CreatePlan method is covered by tests, especially since it involves complex logic and external dependencies.

public async Task<string> CreatePlan(string ask)

Copilot · 2025-02-10T13:25:23Z

samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/DeveloperLead.cs

+            var prompt = $$"""
+                            You are a Dev Lead for an application team, building the application described below. 
+                            Please break down the steps and modules required to develop the complete application, describe each step in detail.
+                            Make prescriptive architecture, language, and frameowrk choices, do not provide a range of choices. 


The word 'frameowrk' is misspelled. It should be 'framework'.

Suggested change

Make prescriptive architecture, language, and frameowrk choices, do not provide a range of choices.

Make prescriptive architecture, language, and framework choices, do not provide a range of choices.

Copilot · 2025-02-10T13:25:24Z

samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/ProductManager.cs

-            var enhancedContext = await AddKnowledge(instruction, "waf",context);
-            return await CallFunction(PMSkills.Readme, enhancedContext);
+            var guidelines = "";// await AddKnowledge(instruction, "waf");
+            var prompt = $$$""""


The string interpolation syntax $$$""" is incorrect. It should be $""".

Suggested change

var prompt = $$$""""

var prompt = $""""

Copilot · 2025-02-10T13:25:24Z

samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/Developer.cs

        catch (Exception ex)
        {
-            _logger.LogError(ex, "Error generating code");
+            logger.LogError(ex, "Error generating code");


The logger variable is not defined. It should be initialized properly, possibly as a private readonly field like _logger.

Suggested change

logger.LogError(ex, "Error generating code");

_logger.LogError(ex, "Error generating code");

kostapetan added 2 commits January 30, 2025 10:52

builds, but doesn't work :) WIP

8efe231

restructure projects and solution

2288bbb

kostapetan had a problem deploying to dev January 30, 2025 11:59 — with GitHub Actions Failure

kostapetan requested a review from Copilot January 30, 2025 14:04

Copilot AI reviewed Jan 30, 2025

View reviewed changes

nuget updates and resources addition to Aspire, WIP

97dc6de

kostapetan had a problem deploying to dev January 30, 2025 15:54 — with GitHub Actions Failure

remove SK

2e1991a

kostapetan had a problem deploying to dev February 5, 2025 10:25 — with GitHub Actions Failure

kostapetan added 2 commits February 5, 2025 11:32

dependencies cleanup

30ffaf3

Keyed chat client

f4f9393

kostapetan had a problem deploying to dev February 5, 2025 11:08 — with GitHub Actions Failure

kostapetan requested a review from Copilot February 5, 2025 11:09

Copilot AI reviewed Feb 5, 2025

View reviewed changes

working

6848905

kostapetan had a problem deploying to dev February 6, 2025 15:22 — with GitHub Actions Failure

vite port and cors fixed

702739b

kostapetan had a problem deploying to dev February 6, 2025 19:25 — with GitHub Actions Failure

cleanup

b49a87a

kostapetan had a problem deploying to dev February 6, 2025 19:57 — with GitHub Actions Failure

Redis for storage and function calling

4f9b0c0

kostapetan had a problem deploying to dev February 7, 2025 11:38 — with GitHub Actions Failure

azure deployment bits (SignalR not working)

cf4077f

kostapetan had a problem deploying to dev February 7, 2025 14:24 — with GitHub Actions Failure

kostapetan added 2 commits February 9, 2025 20:14

deploys to azure works

0c1b235

fixup

2449f3a

kostapetan had a problem deploying to dev February 9, 2025 19:15 — with GitHub Actions Failure

refactor websocket connections state

c2d6573

kostapetan had a problem deploying to dev February 10, 2025 13:17 — with GitHub Actions Failure

kostapetan requested a review from Copilot February 10, 2025 13:23

Copilot AI reviewed Feb 10, 2025

View reviewed changes

refactor Aspire bits + update dependencies

f828598

kostapetan had a problem deploying to dev February 13, 2025 11:09 — with GitHub Actions Failure

kostapetan had a problem deploying to dev February 13, 2025 11:10 — with GitHub Actions Failure

RAG added

4278055

kostapetan had a problem deploying to dev February 14, 2025 17:00 — with GitHub Actions Failure

Minor changes and dispatcher prompt improvement.

975d23d

alessandro-avila had a problem deploying to dev February 18, 2025 13:58 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/support center audio#102

Feature/support center audio#102
kostapetan wants to merge 17 commits intomainfrom
feature/support-center-audio

kostapetan commented Jan 30, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 30, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 5, 2025

Uh oh!

Copilot AI Feb 5, 2025

Uh oh!

Copilot AI Feb 5, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 10, 2025

Uh oh!

Copilot AI Feb 10, 2025

Uh oh!

Copilot AI Feb 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,6 @@
		namespace SupportCenter.ApiService.Agents.Conversation;

	Make prescriptive architecture, language, and frameowrk choices, do not provide a range of choices.
	Make prescriptive architecture, language, and framework choices, do not provide a range of choices.

-            var result = await chatClient.CompleteAsync(prompt);
+            var result = await chatClient.CompleteAsync(prompt);
+            if (result.Message == null)
+            {
+                logger.LogError("Received null Message from chatClient.");
+                return default;
+            }

	logger.LogError(ex, "Error generating code");
	_logger.LogError(ex, "Error generating code");

Conversation

kostapetan commented Jan 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants