Skip to content

Add new badge/certificate authoring#4378

Draft
riknoll wants to merge 2 commits intomasterfrom
new-reward-authoring
Draft

Add new badge/certificate authoring#4378
riknoll wants to merge 2 commits intomasterfrom
new-reward-authoring

Conversation

@riknoll
Copy link
Member

@riknoll riknoll commented Nov 18, 2021

Fixes #4320

This PR is easier to view if you turn on the "ignore whitespace" option in the gear wheel in the "Files Changed" tab.

Adding the new authoring for the various skillmaps that specifies a shorter badge name and a certificate preview image.

This should not be merged until we release the update.

@riknoll
Copy link
Member Author

riknoll commented Nov 18, 2021

BTW I tested this locally and it all looks good

Copy link
Contributor

@kiki-lee kiki-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@abchatra
Copy link
Collaborator

abchatra commented Dec 2, 2021

@riknoll status?

@abchatra
Copy link
Collaborator

abchatra commented Feb 4, 2022

@riknoll this changes still in progress?

@riknoll
Copy link
Member Author

riknoll commented Feb 4, 2022

I think this is out of date, right @kiki-lee?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Badge names are too long

4 participants