Fix blockly dropdown scroll and media not being copied properly#11119
Merged
Fix blockly dropdown scroll and media not being copied properly#11119
Conversation
srietkerk
approved these changes
Feb 17, 2026
Contributor
srietkerk
left a comment
srietkerk
left a comment
There was a problem hiding this comment.
Seems fine to me. Just wanted to ask if the encoding stuff will also effect any of the icons that we use in the editor?
Member
Author
|
nah, those are all svgs which are utf8 encoded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pxt-arcade#7459
fixes microsoft/pxt-arcade#7458
the scroll issue was fixed by editing the overflow css for the dropdown content. this change makes me a little nervous, but i tested all the fields i could think of and they all seem to be working properly
the media issue was caused by gulp trying to read all of the binary files as utf8 encoded. turns out all the sounds were broken too but nobody noticed :)