add monkey patch workaround for blockly focus issue when deleting block#11122
Open
add monkey patch workaround for blockly focus issue when deleting block#11122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pxt-arcade#7392
this adds a monkey patch workaround for the annoying blockly focus behavior when deleting a top-level block
the only changed lines from the core implementation are lines 50-58, which now calculate a radius based off of the workspace view width/height rather than only looking in a radius of 0.
...well, i also had to replace the
this.svgGroupreference with a call tothis.getSvgRoot()(which returns the same element) becausesvgGroupis private, but it's fundamentally unchangedif you want to diff against blockly's version, it's here
@microbit-robert FYI