Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brings back the old queue play instructions for mixer but keeps all of the new stuff. as a bonus, i hooked up the oscilloscope to the old code so you can still see an accurate waveform in the sound effect editor.
we got a few complaints on the forum about the new sound quality and after listening to some examples, i agree. the audio worklet may be hardware accurate, but it can't beat the builtin web audio API's anti aliasing oscillators for audio quality. still, i haven't given up on it so i've chosen not to revert the commit; all of the code is still there and if we ever overhaul the synth on hardware to make improvements then we can port changes over here and try again.
i've tested this against v2 to make sure that everything sounds the way it used to.