Skip to content

fix: add resource block var#477

Merged
rzhao271 merged 1 commit into
mainfrom
rzhao271/distant-warbler
Jun 15, 2026
Merged

fix: add resource block var#477
rzhao271 merged 1 commit into
mainfrom
rzhao271/distant-warbler

Conversation

@rzhao271

@rzhao271 rzhao271 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This PR allows our pipelines to build the full Windows binary with custom product name info once again.

Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=447930&view=results

@rzhao271 rzhao271 added this to the 1.126.0 milestone Jun 15, 2026
@rzhao271 rzhao271 self-assigned this Jun 15, 2026
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Test Coverage Report (Linux)

Metric Value
Current Coverage 79.9%
Base Branch Coverage 79.9%
Delta 0% ➖

Coverage unchanged.

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 48ms 551ms 78ms -30ms
Full Refresh 94ms 26381ms 175ms -81ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Performance Report (Linux) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 1ms 1ms 1ms 0ms 0%
Full Refresh 57ms 358ms 63ms -6ms 0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Performance Report (Windows) ✅

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 8ms 11ms 10ms -2ms -20%
Full Refresh 139ms 424ms 157ms -18ms -11.5%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.


Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Test Coverage Report (Windows)

Metric Value
Current Coverage 76.94%
Base Branch Coverage 76.94%
Delta 0% ➖

Coverage unchanged.

@rzhao271 rzhao271 marked this pull request as ready for review June 15, 2026 23:33
@rzhao271

Copy link
Copy Markdown
Contributor Author

@rzhao271 rzhao271 enabled auto-merge (squash) June 15, 2026 23:41
@rzhao271 rzhao271 merged commit 89bf1c0 into main Jun 15, 2026
56 of 58 checks passed
@rzhao271 rzhao271 deleted the rzhao271/distant-warbler branch June 15, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants