Allow dynamic constant values to coerce to static across callable boundaries in RCA#3502
Open
swernli wants to merge 1 commit into
Open
Allow dynamic constant values to coerce to static across callable boundaries in RCA#3502swernli wants to merge 1 commit into
swernli wants to merge 1 commit into
Conversation
…ndaries in RCA This adds functionality to RCA that coerces some dynamic constants into static during calculation of callable arguments, mimicking functionality added to partial eval in #3491. This allows APIs like `Std.TableLookup.Select` to pass RCA, but notably only fixes generation of body implementation; calls to `Adjoint Select` invoke a code path that passes RCA but fails in partial eval due to missing support for emitting arrays with dynamic contents into QIR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds functionality to RCA that coerces some dynamic constants into static during calculation of callable arguments, mimicking functionality added to partial eval in #3491. This allows APIs like
Std.TableLookup.Selectto pass RCA, but notably only fixes generation of body implementation; calls toAdjoint Selectinvoke a code path that passes RCA but fails in partial eval due to missing support for emitting arrays with dynamic contents into QIR.