Add arithmetic library#3505
Open
fedimser wants to merge 10 commits into
Open
Conversation
fedimser
marked this pull request as ready for review
July 23, 2026 17:55
fedimser
requested review from
amcasey,
billti,
idavis,
orpuente-MS and
swernli
as code owners
July 23, 2026 17:55
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/microsoft/qdk/tree/fedimser/arith-lib/library/arithmetic
This is tested by Python tests that use qdk.Context (wrapped in a pytest ficture) and ArithmeticTestHelper. Tests are in library/arithmetic/test and I manually added them to paths for integration tests in build.py. I am not sure if it's the best approach.