Remove internal CodeGenMember propeties from model factory method#10119
Open
MaiLinhP wants to merge 6 commits intomicrosoft:mainfrom
Open
Remove internal CodeGenMember propeties from model factory method#10119MaiLinhP wants to merge 6 commits intomicrosoft:mainfrom
MaiLinhP wants to merge 6 commits intomicrosoft:mainfrom
Conversation
commit: |
Contributor
|
No changes needing a change description found. |
| } | ||
|
|
||
| // Skip parameters for properties that were customized via CodeGenMember to be non-public | ||
| if (param.Property?.OriginalName != null |
Contributor
There was a problem hiding this comment.
Should this just skip any non public/protected properties?
Member
Author
There was a problem hiding this comment.
I tried to skip non-public and non public/protected. Both of these checks are still too broad which caused removal of some necessary parameters and regen failures. I've reverted back to checking specifically for CodeGenMember renamed parameters :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When marking properties as CodeGenMember, the generator renamed them to internal (ex: Latitude -> latitudeInternal), but ModelFactoryProvider still includes these parameters and expose them to public API. This makes sure those parameters are skipped instead.