Skip to content

[angle] Fix gcc13 compilation error #32499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BillyONeal merged 2 commits into from
Jul 11, 2023
Merged

[angle] Fix gcc13 compilation error #32499

BillyONeal merged 2 commits into from
Jul 11, 2023

Conversation

@jimwang118
Copy link
Contributor

@jimwang118 jimwang118 commented Jul 11, 2023

Fixes #32494
/home/vliumonica/angle/buildtrees/angle/src/fb17168c17-081a7ef021.clean/include/GLSLANG/ShaderVars.h:127:70: error: ‘uint32_t’ has not been declared
Add the header file corresponding to uint32_t.
Usage test pass with following triplets:

x64-linux
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jul 11, 2023
@Cheney-W Cheney-W marked this pull request as ready for review July 11, 2023 09:59
@Cheney-W Cheney-W added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jul 11, 2023
@BillyONeal
Copy link
Member

BillyONeal commented Jul 11, 2023

Thanks for the header update! Can you make sure that this fix is submitted upstream?

@BillyONeal BillyONeal merged commit 4d1e050 into microsoft:master Jul 11, 2023
@jimwang118
Copy link
Contributor Author

jimwang118 commented Jul 12, 2023

Thanks for the header update! Can you make sure that this fix is submitted upstream?

I submitted a PR 95 upstream.

@jimwang118 jimwang118 deleted the fixangle branch August 30, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Cheney-W Cheney-W Cheney-W approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Cheney-W Cheney-W

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[angle] Build error: 'uint32_t' has not been declared

3 participants

@jimwang118 @BillyONeal @Cheney-W