Prepare extension for integration with Azure Resources API (v4)#992
Draft
MicroFish91 wants to merge 13 commits intomainfrom
Draft
Prepare extension for integration with Azure Resources API (v4)#992MicroFish91 wants to merge 13 commits intomainfrom
MicroFish91 wants to merge 13 commits intomainfrom
Conversation
Merged
5 tasks
Comment on lines
30
to
31
| ext.rgApiV2 = rgApiV2; | ||
| ext.rgApiV2.resources.registerAzureResourceBranchDataProvider(AzExtResourceType.ContainerAppsEnvironment, ext.branchDataProvider); |
Contributor
There was a problem hiding this comment.
I feel like these two parts should stay in the extension.ts since they are kinda "what do we do on activation". They can be passed in as a callback to this method.
Not stuck on this, but let me know what you think.
Contributor
Author
There was a problem hiding this comment.
Yeah that's a good idea so people don't have to hunt around to figure out the activation logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample code for v4 integration, relies on updates from Azure Resources, will post corresponding PR(s) within the next day or two.
Todo: Discuss how we want to measure activation / handshake times in telemetry