Add changes for re running "Deploy to Container App" command #999
Open
Add changes for re running "Deploy to Container App" command #999
Conversation
nturinski
reviewed
Jan 14, 2026
|
|
||
| public confirmationViewProperty(context: T): ConfirmationViewProperty { | ||
| return { | ||
| name: "Container Apps Environment", |
|
|
||
| if (context.subscriptionId && node && imageSource) { | ||
| // If this command gets re run we only want the internal portion of the command to run, so we set the callbackid | ||
| context.callbackId = 'containerApps.deployContainerAppInternal'; |
Member
There was a problem hiding this comment.
Can you explain what this means?
| } | ||
|
|
||
| function isCopilotUserInput(context: IActionContext): boolean { | ||
| return context.ui.constructor.name === 'CopilotUserInput'; |
Member
There was a problem hiding this comment.
Can you do context.ui instanceof CopilotUserInput? I think it's a more robust detection method.
nturinski
reviewed
Jan 14, 2026
| import { type ManagedEnvironmentContext } from "../../ManagedEnvironmentContext"; | ||
|
|
||
| export interface ManagedIdentityRegistryCredentialsContext extends CreateAcrContext, ManagedEnvironmentRequiredContext, IContainerAppContext { | ||
| export interface ManagedIdentityRegistryCredentialsContext extends CreateAcrContext, ManagedEnvironmentContext, IContainerAppContext { |
Member
There was a problem hiding this comment.
Context loosened from ManagedEnvironmentRequiredContext → ManagedEnvironmentContext.
This is fine only if all consumers tolerate managedEnvironment being undefined. Worth a quick scan of downstream usage.
nturinski
reviewed
Jan 14, 2026
| wizardContext.telemetry.properties.revisionMode = item.containerApp.revisionsMode; | ||
|
|
||
| const confirmationViewTitle: string = localize('summary', 'Summary'); | ||
| let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input proceeding the changed input will need to change as well'); |
Member
There was a problem hiding this comment.
Suggested change
| let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input proceeding the changed input will need to change as well'); | |
| let confirmationViewDescription: string = localize('viewDescription', 'Please select an input you would like to change. Note: Any input preceding the changed input will need to change as well'); |
nturinski
reviewed
Jan 14, 2026
| if (wizardContext.ui instanceof CopilotUserInput) { | ||
| promptSteps.push(new OpenLoadingViewStep()); | ||
| if (isCopilotUserInput(wizardContext)) { | ||
| confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input proceeding the modified input will need to change as well'); |
Member
There was a problem hiding this comment.
Suggested change
| confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input proceeding the modified input will need to change as well'); | |
| confirmationViewDescription = localize('viewDescription', 'Please review AI generated inputs and select any you would like to modify. Note: Any input preceding the modified input will need to change as well'); |
|
@copilot fix all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a couple things:
Things to do: