Add receiver method to the type definition for AzureExtensionApi#1285
Closed
MicroFish91 wants to merge 5 commits intomainfrom
Closed
Add receiver method to the type definition for AzureExtensionApi#1285MicroFish91 wants to merge 5 commits intomainfrom
AzureExtensionApi#1285MicroFish91 wants to merge 5 commits intomainfrom
Conversation
Contributor
bwateratmsft
left a comment
bwateratmsft
left a comment
There was a problem hiding this comment.
Do you need to also run npm run api-extractor or does that not produce any committable changes?
MicroFish91
force-pushed
the
mwf/lovely-jade
branch
from
7660abc to
500b37d
Compare
Contributor
Author
|
Running api-extractor produced no committable changes! |
Member
|
Running api-extractor alone won't produce changes, you have to copy the file that it produces into /api/docs/. This is from api/CONTRIBUTING.md:
|
Contributor
Author
|
Oops just kidding, thanks I definitely missed that last step, but also, I just realized I don't actually need to publish this early for the types after all, so closing this in favor of the other PR that I'll be taking out of draft soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need this type updated so I can include it in utils.
I need all the package typings aligned so that typescript stops yelling at me :P
Plan to eventually add a README link in the comment as well, but that would be in the next iteration.
Needed as a prerequisite for this:
#1284