Draft
Conversation
Member
|
Do we need to reevaluate the need for this now that we've fixed the resolver caching? |
Member
Author
|
Hmm, I don't really see the harm in merging this considering the itemCache already existed. Might as well leverage it if we had already loaded the child once before. Other than using the cache, I don't think that this changes the behavior of anything else. |
Contributor
|
Converting old PR to draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was already an item cache being used for storing the relationship data between parent and child. I was able to just leverage that to make reveal a lot faster if something has already been loaded before.
The next step to improving performance is to the do following across extensions:
ple
GETcalls use theLISTcall. There is some concern about the caching that messes things up that we should consider, however, such as deleting too many resources at once and the cached list doesn't update to reflect that.