-
Notifications
You must be signed in to change notification settings - Fork 50
Lazy load some more things for better load times #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| "@azure/arm-appservice": "*", | ||
| "@azure/arm-authorization": "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @microsoft/vscode-azext-azureappservice and @microsoft/vscode-azext-azureutils packages already depend on these two. Using "*" is a nice way of saying "just give me the same thing they're using".
| "esbuild-plugin-copy": "*" | ||
| }, | ||
| "dependencies": { | ||
| "@azure/arm-authorization": "^9.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We weren't directly using the package, only the types.
| import { ext } from '../extensionVariables'; | ||
| import { Lazy } from './lazy'; | ||
|
|
||
| const armAuthLazy = new Lazy(async () => await import('@azure/arm-authorization')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't used.
TODO: