feat: array value completion from contributions#276
Open
leonrinkel wants to merge 1 commit intomicrosoft:mainfrom
Open
feat: array value completion from contributions#276leonrinkel wants to merge 1 commit intomicrosoft:mainfrom
leonrinkel wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This enables a JSONWorkerContribution to contribute array value completions.
Author
|
@microsoft-github-policy-service agree |
Collaborator
|
Thanks for looking at this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
JSONWorkerContributionto contribute array value completions. I originally requested this feature in #263 and have now taken a first stab at implementing it. To avoid changing the API, I reusedcollectValueCompletions, but it doesn't feel like the best fit for this use case. Another approach might be introducing something likecollectArrayCompletions, possibly with better fitting attributes like the index the cursor is at. I'm happy to hear your thoughts and feedback!