fix IPC handle is longer than 103 chars error for CI#1565
Merged
Conversation
eleanorjboyd
changed the title
eleanorjboyd
added
bug
eleanorjboyd
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses failures caused by overly long IPC/unix-socket paths during VS Code test runs (notably on macOS), and improves fast-path environment resolution by avoiding spawning PET when a cached interpreter path no longer exists.
Changes:
- Shorten VS Code test
--user-data-dirby moving it underos.tmpdir()and seed test settings via a reusable Node script in CI. - Add a cheap filesystem existence check to
tryFastPathGet()so missing cached interpreter paths fall through without spawning PET. - Expand unit test coverage to validate the new “cached path missing on disk” behavior for both workspace and global caches.
Show a summary per file
| File | Description |
|---|---|
| src/test/managers/common/fastPath.unit.test.ts | Updates test paths and adds coverage for missing persisted-path fast-path behavior. |
| src/managers/common/fastPath.ts | Adds persistedPathExists() and short-circuits fast-path resolution when cached paths are missing. |
| build/setup-test-user-data.mjs | New helper to create a short test user-data settings directory (CI seeding). |
| .vscode-test.mjs | Switches VS Code test user-data dir to a short tmpdir-based path to avoid socket-length limits. |
| .github/workflows/push-check.yml | Uses the new setup script instead of inline shell to seed test settings. |
| .github/workflows/pr-check.yml | Uses the new setup script instead of inline shell to seed test settings. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 1
The fast-path resolver now does a real fs.promises.access on the persisted path. The manager-level fast-path tests use synthetic paths that don't exist, causing tryFastPathGet to fall through to real initialization (and TypeError / 180s timeouts). Stub access to resolve so the fast path still fires.
Move the python.useEnvironmentsExtension=true seed into the test config so local 'npm run smoke-test' / e2e / integration runs match CI. Without it the extension short-circuits during activation and registration tests fail. Drops the duplicated CI step and helper.
dmitrivMS
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.