Rename PEP723 telemetry events to inlineScript#1578
Merged
StellaHuang95 merged 1 commit intoJun 11, 2026
Conversation
Trying an alphabetic prefix to debug why these events aren't reaching Kusto. The data platform team confirmed every other event from a test session arrived but the two PEP 723 ones were dropped without an explanation; one guess is the digits in the name/GDPR key are tripping something in ingestion. No behavior change otherwise — events are now inlineScript.detected / inlineScript.edited and the GDPR keys match the wire names exactly. Also aligned the enum names, jsdoc, test titles, and the comment in extension.ts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
StellaHuang95
force-pushed
the
rename-inline-script-telemetry
branch
from
8704aa9 to
3256564
Compare
edvilme
approved these changes
Jun 11, 2026
edvilme
left a comment
edvilme
left a comment
Contributor
There was a problem hiding this comment.
LGTM, hopefully this helps :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rename the two PEP 723 telemetry events to use an
inlineScriptprefix instead ofPEP723:PEP723.DETECTEDinlineScript.detectedPEP723.EDITEDinlineScript.editedEventNames.PEP723_DETECTEDEventNames.INLINE_SCRIPT_DETECTEDEventNames.PEP723_EDITEDEventNames.INLINE_SCRIPT_EDITEDThe new names are consistent with the rest of the module —
inlineScriptMetadata.ts,InlineScriptLazyDetector,readInlineScriptMetadataFromFile,InlineScriptMetadata— and drop the PEP number from anything that leaves the machine.The GDPR annotation keys were also realigned to match the wire names exactly (
"inlineScript.detected"/"inlineScript.edited").Why
I talked to the data platform team about why
PEP723.DETECTED/PEP723.EDITEDwere missing from Kusto. They asked me to manually trigger the events and gave them my VS Code session ID. After I did, they could see every other event from that session — but not the two PEP 723 ones. They didn't know what was filtering them out either.I don't know what's wrong yet. One guess is that the digits in the event name / GDPR key are tripping something in the ingestion or sanitization pipeline. This PR drops the numbers and renames the events to a clean alphabetic prefix to try again; if events start showing up in Kusto after this lands, that's our culprit.
Scope
Telemetry-only rename — no behavior change. Code that refers to the PEP 723 spec (parser, docstrings, design docs, API jsdoc) is intentionally untouched.
Files changed
src/common/telemetry/constants.ts— enum members, jsdoc, and__GDPR__annotationssrc/features/inlineScriptLazyDetector.ts—sendTelemetryEventcalls + class jsdoc + field comments + handler jsdocsrc/extension.ts— comment quoting the event namessrc/test/features/inlineScriptLazyDetector.unit.test.ts— section comments + 10 test titles + 16EventNames.*referencesVerified
npm run lintcleannpm run unittest— all 1141 tests pass; the 10 renamedinlineScript.*tests show the new names