Skip to content

Refactor smoke action bar packager wait #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EmmaYuan1015 wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Refactor smoke action bar packager wait #2686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions test/smoke/suites/actionBar.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import { SmokeTestLogger } from "./helper/smokeTestLogger";
import { app, screenshots } from "./main";
import { ElementHelper } from "./helper/elementHelper";
import { Element } from "./helper/constants";
import { WaitHelper } from "./helper/waitHelper";
import { ComponentHelper } from "./helper/componentHelper";
import { TimeoutConstants } from "./helper/timeoutConstants";
import assert = require("assert");

export function startActionBarTests(): void {
Expand Down Expand Up @@ -58,19 +58,10 @@ export function startActionBarTests(): void {
);
await actionButton.click();

await WaitHelper.waitIsTrue(async () => {
const packager = await ComponentHelper.getReactNativePackager();
const currentState = await packager.getAttribute("aria-label");
try {
assert.ok(
currentState?.includes("primitive-square"),
`Expected packager state to include 'primitive-square', got: ${currentState}`,
);
return true;
} catch {
return false;
}
});
await ComponentHelper.waitPackagerStateIncludes(
"primitive-square",
TimeoutConstants.PACKAGER_STATE_TIMEOUT,
);
});
});
}