Skip to content

Assert action bar wait result to avoid false positives #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
EmmaYuan1015 wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −1
Draft

Assert action bar wait result to avoid false positives #2689

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ec304f
fix(smoke): assert action bar wait result to avoid false positives
EmmaYuan1015 May 28, 2026
c013cb8
Merge branch 'master' into smoke-actionbar-timeout-assertion
EmmaYuan1015 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test/smoke/suites/actionBar.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function startActionBarTests(): void {
);
await actionButton.click();

await WaitHelper.waitIsTrue(async () => {
const isPackagerStateUpdated = await WaitHelper.waitIsTrue(async () => {
const packager = await ComponentHelper.getReactNativePackager();
const currentState = await packager.getAttribute("aria-label");
try {
Expand All @@ -71,6 +71,11 @@ export function startActionBarTests(): void {
return false;
}
});

assert.ok(
isPackagerStateUpdated,
"Packager state did not update to include 'primitive-square' within timeout",
);
});
});
}
Loading