Skip to content

fix: persist test coverage sort order across sessions #304979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connor4312 merged 2 commits into from
Mar 26, 2026
+11 −0
Merged

fix: persist test coverage sort order across sessions #304979

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b73d16
fix: persist test coverage sort order across sessions
yogeshwaran-c Mar 26, 2026
41bed90
fix: correct const enum validation in coverage sort persistence
yogeshwaran-c Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/vs/workbench/contrib/testing/browser/testCoverageView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ import { IKeybindingService } from '../../../../platform/keybinding/common/keybi
import { ILabelService } from '../../../../platform/label/common/label.js';
import { WorkbenchCompressibleObjectTree } from '../../../../platform/list/browser/listService.js';
import { IOpenerService } from '../../../../platform/opener/common/opener.js';
import { IStorageService, StorageScope, StorageTarget } from '../../../../platform/storage/common/storage.js';
import { IQuickInputService, IQuickPickItem, QuickPickInput } from '../../../../platform/quickinput/common/quickInput.js';
import { IThemeService } from '../../../../platform/theme/common/themeService.js';
import { IResourceLabel, ResourceLabels } from '../../../browser/labels.js';
Expand Down Expand Up @@ -78,13 +79,23 @@ export class TestCoverageView extends ViewPane {
@IThemeService themeService: IThemeService,
@IHoverService hoverService: IHoverService,
@ITestCoverageService private readonly coverageService: ITestCoverageService,
@IStorageService private readonly storageService: IStorageService,
) {
super(options, keybindingService, contextMenuService, configurationService, contextKeyService, viewDescriptorService, instantiationService, openerService, themeService, hoverService);
const storedOrder = this.storageService.getNumber('testing.coverageSortOrder', StorageScope.WORKSPACE);
if (storedOrder !== undefined && storedOrder >= CoverageSortOrder.Coverage && storedOrder <= CoverageSortOrder.Name) {
this.sortOrder.set(storedOrder, undefined);
}
}

protected override renderBody(container: HTMLElement): void {
super.renderBody(container);

this._register(autorun(reader => {
const order = this.sortOrder.read(reader);
this.storageService.store('testing.coverageSortOrder', order, StorageScope.WORKSPACE, StorageTarget.MACHINE);
}));

const labels = this._register(this.instantiationService.createInstance(ResourceLabels, { onDidChangeVisibility: this.onDidChangeBodyVisibility }));

this._register(autorun(reader => {
Expand Down
Loading