fix: strip @sort qualifier from MCP Servers view search query#304985
Closed
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Closed
fix: strip @sort qualifier from MCP Servers view search query#304985yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
yogeshwaran-c wants to merge 1 commit intomicrosoft:mainfrom
Conversation
When the user types '@mcp @sort:name' in the Extensions search box, the MCP Servers view only strips '@mcp' but passes '@sort:name' as literal search text to queryGallery, which finds no results and shows an empty list. Strip the @sort qualifier using the same regex pattern as the extensions view before passing the text to the gallery query. Closes microsoft#296801
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When typing
@mcp @sort:namein the Extensions search box, the MCP Servers view becomes empty showing "No MCP Servers found." This happens because thequery()method only strips the@mcpprefix, leaving@sort:nameas literal search text passed toqueryGallery(), which finds no matching results.Closes #296801
What is the new behavior?
The
@sort:qualifier is now stripped from the query text before it is passed toqueryGallery(). This uses the same regex pattern (/@sort:(\w+)(-\w*)?/g) that the extensions view already uses to handle sort qualifiers.After the fix,
@mcp @sort:namecorrectly shows the MCP Servers list (since the gallery search text becomes empty after stripping both qualifiers).Additional context
src/vs/workbench/contrib/mcp/browser/mcpServersView.tsextensionsViews.tsin multiple places for the same purpose