Improve terminal output handling to hide output when not required#305035
Merged
DonJayamanne merged 4 commits intomainfrom Mar 26, 2026
Merged
Improve terminal output handling to hide output when not required#305035DonJayamanne merged 4 commits intomainfrom
DonJayamanne merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts how chat terminal tool invocations render their output area so “display-only” invocations (no terminal session and no stored output) don’t show an unnecessary/empty output section, addressing confusion and “terminal no longer available” UX issues reported around Copilot CLI terminal handling.
Changes:
- Only appends the terminal output section DOM when there’s an active terminal session or stored output.
- Adds a “has terminal session” flag to the output section and suppresses the unavailable-message rendering when no session exists.
...rib/chat/browser/widget/chatContentParts/toolInvocationParts/chatTerminalToolProgressPart.ts
Show resolved
Hide resolved
meganrogge
approved these changes
Mar 26, 2026
Collaborator
|
@DonJayamanne when/why is this the case? 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304507
@meganrogge /cc