Fix ctrl+/- not working on Windows Copilot CLI#305037
Merged
anthonykim1 merged 8 commits intomainfrom Mar 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes terminal zoom keybindings (Ctrl+/- on Windows, Cmd+=/- on macOS) being consumed by the shell (eg when kitty keyboard protocol is enabled), which impacts the Copilot CLI experience in the integrated terminal.
Changes:
- Add
workbench.action.zoomIn/zoomOut/zoomResettoDEFAULT_COMMANDS_TO_SKIP_SHELLso VS Code always handles these keybindings while the terminal is focused. - Refactor
TerminalInstancetest setup to awaitxtermReadyPromiseand add coverage around key event interception + default skip list contents.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/workbench/contrib/terminal/test/browser/terminalInstance.test.ts |
Adds/adjusts tests to validate terminal key event interception behavior and asserts zoom commands are in the default skip list. |
src/vs/workbench/contrib/terminal/common/terminal.ts |
Ensures zoom commands are skipped by the shell by default, preventing kitty protocol from consuming them. |
src/vs/workbench/contrib/terminal/test/browser/terminalInstance.test.ts
Outdated
Show resolved
Hide resolved
anthonykim1
commented
Mar 26, 2026
rzhao271
previously approved these changes
Mar 26, 2026
rzhao271
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #305028
After this PR, should work like:
ctrl+and-.mp4
Related: #303712