Fix line count handling in snapshot output rendering#305039
Open
DonJayamanne wants to merge 2 commits intomainfrom
Open
Fix line count handling in snapshot output rendering#305039DonJayamanne wants to merge 2 commits intomainfrom
DonJayamanne wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes truncated/missing terminal snapshot output rendering in the chat terminal tool progress UI (notably affecting Copilot CLI sessions) by ensuring layout calculations don’t incorrectly fall back to 0 lines when lineCount isn’t present.
Changes:
- Preserve the previously rendered line count when re-laying out an existing snapshot mirror and the incoming snapshot omits
lineCount.
meganrogge
approved these changes
Mar 26, 2026
Collaborator
meganrogge
left a comment
meganrogge
left a comment
There was a problem hiding this comment.
When/why does this occur?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #303265