fix: remove left offset on right-aligned hover to prevent border clipping#305052
Open
jaydeep-pipaliya wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: remove left offset on right-aligned hover to prevent border clipping#305052jaydeep-pipaliya wants to merge 1 commit intomicrosoft:mainfrom
jaydeep-pipaliya wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…ping The right-aligned hover had a CSS `left: 1px` hack that shifted the hover widget 1px to the right, causing the right border to be clipped when the window is narrow. The JS positioning logic already accounts for edge margins via HoverWindowEdgeMargin, making this offset unnecessary. Fixes microsoft#127438
jaydeep-pipaliya
force-pushed
the
fix/hover-right-border-clipping
branch
from
4b514e7 to
11ab120
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the right border being clipped on right-aligned hover widgets when the window is narrow.
Root cause: The
.monaco-hover.workbench-hover.right-alignedCSS rule had aleft: 1pxhack that shifted the hover 1px to the right. When the hover was already positioned at the right edge of the viewport (viacomputeXCordinatewithHoverWindowEdgeMargin), this extra 1px offset pushed the right border outside the visible area.Fix: Removed the
left: 1pxCSS offset. The JS positioning logic incomputeXCordinatealready handles edge margins correctly viaConstants.HoverWindowEdgeMargin, making the CSS offset unnecessary.Fixes #127438
Test plan
tooltip2(markdown tooltip)