Browser Search#317408
Draft
jruales wants to merge 14 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-pass “search from the integrated browser address bar” support by classifying address-bar input as URL vs query, building a search URL for configured engines, and wiring UI/telemetry updates in the integrated browser editor.
Changes:
- Introduces shared address-bar input classification + search URL construction utilities (with unit tests).
- Adds experimental settings for enabling address-bar search and selecting a search engine.
- Updates the integrated browser editor to (optionally) search on Enter, show an inline action preview icon, and emit distinct telemetry for search vs URL navigation.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/browserView/test/common/browserSearch.test.ts | Adds unit coverage for input classification and search URL building. |
| src/vs/workbench/contrib/browserView/electron-browser/media/browser.css | Styles for the address-bar “search vs URL” preview indicator. |
| src/vs/workbench/contrib/browserView/electron-browser/features/browserSearchFeatures.ts | Registers experimental settings for address-bar search and engine choice. |
| src/vs/workbench/contrib/browserView/electron-browser/browserView.contribution.ts | Wires the new search settings contribution into the integrated browser feature set. |
| src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts | Integrates search behavior on navigation, dynamic placeholder, and preview-indicator updates. |
| src/vs/workbench/contrib/browserView/electron-browser/addressBarInputPreviewWidget.ts | Implements the decorative address-bar action preview widget (magnifier/globe). |
| src/vs/workbench/contrib/browserView/common/browserView.ts | Extends navigation telemetry + model API to distinguish search-triggered navigations. |
| src/vs/workbench/contrib/browserView/common/browserSearch.ts | New shared utilities: input classification and per-engine search URL construction. |
Copilot's findings
- Files reviewed: 8/8 changed files
- Comments generated: 1
kycutler
reviewed
May 19, 2026
This reverts commit 6676b06.
…er-search # Conflicts: # src/vs/workbench/contrib/browserView/common/browserView.ts # src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts # src/vs/workbench/contrib/browserView/electron-browser/media/browser.css
…er-search # Conflicts: # src/vs/workbench/contrib/browserView/electron-browser/widgets/browserUrlBarWidget.ts
kycutler
reviewed
Jun 3, 2026
| */ | ||
| export const enum BrowserSearchEngineId { | ||
| Bing = 'bing', | ||
| Yahoo = 'yahoo', |
Contributor
There was a problem hiding this comment.
Should we just go in alphabetical order to be less opinionated
Address PR review: move address-bar search resolution into the nav bar so navigate()/loadURL() take a plain URL. - navigate() is now a pure load-this-URL entry point taking an optional telemetry source; removes IBrowserNavigateOptions and the config-service/search dependencies from BrowserEditorInput. - loadURL() takes a BrowserNavigationSource override instead of fromSearch; http:// fixup runs unconditionally again. - Collapse IBrowserUrlPrimaryAction into IUrlPickerItem; getPrimaryActions returns picker items directly and raw-text commits route through the host default item. - Remove now-dead resolveAddressBarNavigation and its tests. - Drop the stale 'first entry is the default' comment on BROWSER_SEARCH_ENGINES.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.