Skip to content

Fix browser overflowing container in some scenarios #320269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kycutler merged 2 commits into from
Jun 7, 2026
+6 −7
Merged

Fix browser overflowing container in some scenarios #320269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39803f9
Fix browser overflowing container in some scenarios
kycutler Jun 6, 2026
51d0e54
feedback
kycutler Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...workbench/contrib/browserView/electron-browser/features/webContentsViewRendererFeature.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class WebContentsViewRendererFeature extends BrowserEditorContribution {

override beforeContainerLayout(): IContainerLayoutOverride {
return {
padding: { right: 3, bottom: 3, left: 3 },
padding: { top: 3, right: 3, bottom: 3, left: 3 },

// Snap CSS-pixel values down so `v × hostZoom` is an exact integer:
// main places the WCV at `round(v × hostZoom) × systemDPR` physical
Expand Down
11 changes: 5 additions & 6 deletions src/vs/workbench/contrib/browserView/electron-browser/media/browser.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
.browser-navbar {
display: flex;
align-items: center;
padding: 6px 8px;
padding: 6px 8px 3px 8px;
background-color: var(--vscode-editor-background);
flex-shrink: 0;
gap: 8px;
Expand Down Expand Up @@ -111,8 +111,6 @@
font-size: 12px;
background-color: var(--vscode-editorWidget-background);
color: var(--vscode-editorWidget-foreground);
border-bottom: 1px solid var(--vscode-editorWidget-border, transparent);
margin-bottom: 3px;

.browser-emulation-toolbar-groups {
display: flex;
Expand Down Expand Up @@ -332,11 +330,11 @@
}

.browser-container-wrapper {
flex: 1;
flex: 1 1 auto;
min-height: 0;
position: relative;
margin-top: 1px;
box-sizing: border-box;
overflow: hidden;
}
Comment thread
kycutler marked this conversation as resolved.

.browser-container {
Expand Down Expand Up @@ -595,7 +593,7 @@
border-radius: 0;
border: none;
top: 0 !important;
padding: 2px 8px 6px 12px;
padding: 4px 8px 4px 12px;
transition: none;
background: none !important;

Expand All @@ -606,6 +604,7 @@
.monaco-sash {
width: 2px !important;
height: calc(100% - 4px);
margin-top: 2px;
border-radius: var(--vscode-cornerRadius-circle);

&::before {
Expand Down
Loading