Add local agent host test#320289
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds coverage for running the Agents Window against a local Agent Host (AHP) in smoke tests, and tightens several Agent Host/session-type synchronization behaviors to reduce UI/session churn during turns.
Changes:
- Add a new smoke test suite that launches the Agents Window and validates a “Local Agent Host” session end-to-end, including verifying AHP JSONL transcript output.
- Make the session-type picker automation resilient to late/async provider registration by polling for a specific label.
- Improve Agent Host session stability by (a) pinning in-flight subscriptions, (b) avoiding redundant “custom agents changed” events on non-agent root deltas, and (c) overlaying state-manager-announced sessions when providers transiently return empty
listSessions()results.
Show a summary per file
| File | Description |
|---|---|
| test/smoke/src/areas/agentsWindow/agentsWindow.test.ts | Adds a new smoke suite for local Agent Host sessions and validates AHP JSONL logging. |
| test/automation/src/agentsWindow.ts | Updates session-type picker automation to wait for a specific provider label to appear. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostSessionHandler.ts | Pins session subscriptions while awaiting first snapshot to avoid hangs if refcounts drop. |
| src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatContribution.ts | Adds a smoke-test-only auth token escape hatch gated by the smoke test driver flag. |
| src/vs/sessions/contrib/providers/agentHost/test/browser/localAgentHostSessionsProvider.test.ts | Extends tests to ensure “custom agents changed” only fires when the agents slice actually changes. |
| src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts | Suppresses custom-agent/customization change events unless the agents reference changes. |
| src/vs/platform/agentHost/node/agentService.ts | Overlays session summaries announced by the state manager when providers’ listSessions() snapshots transiently omit sessions. |
| src/vs/platform/agentHost/node/agentHostStateManager.ts | Exposes announced session summaries for AgentService fallback behavior. |
Copilot's findings
- Files reviewed: 8/8 changed files
- Comments generated: 1
a2272db to
2bc2af2
Compare
2bc2af2 to
ff37a65
Compare
justschen
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#317981